Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1434033
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file |
| Date | 2016-06-29 22:20 +0200 |
| Message-ID | <rPu7M-go-25@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <rP71w-2K4-5@gated-at.bofh.it> <rPovo-5ep-21@gated-at.bofh.it> <rPsz0-7FB-35@gated-at.bofh.it> <rPsIF-7IY-1@gated-at.bofh.it> <rPtY6-d1-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jun 29, 2016 at 04:08:20PM -0400, Jon Mason wrote:
> On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote:
> >> On 06/29/2016 07:13 AM, Andrew Lunn wrote:
> >> > Hi Jon
> >> >
> >> > I know you are just refactoring code, but at some point it would be
> >> > good to take a closer look at this MDIO bus driver.
> >
> >> And, to re-iterate all of your points are valid, but this is premature
> >
> > We agree then :-)
> >
> > Andrew
>
> I also agree with all of your points, but hope this is not something
> that would prevent this patch series from being acceptable.
No, it is acceptable as is.
However, it would be nice the clean up the mess, especially if you are
planning on using this code with new platforms, not just legacy stuff
which is bit rotting.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-28 21:40 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-28 22:10 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 16:20 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Florian Fainelli <f.fainelli@gmail.com> - 2016-06-29 20:40 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 20:50 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-29 22:10 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 22:20 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-29 22:40 +0200
csiph-web