Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

From	Jon Mason <jon.mason@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file
Date	2016-06-29 22:10 +0200
Message-ID	<rPtY6-d1-9@gated-at.bofh.it> (permalink)
References	<rP71w-2K4-7@gated-at.bofh.it> <rP71w-2K4-5@gated-at.bofh.it> <rPovo-5ep-21@gated-at.bofh.it> <rPsz0-7FB-35@gated-at.bofh.it> <rPsIF-7IY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote:
>> On 06/29/2016 07:13 AM, Andrew Lunn wrote:
>> > Hi Jon
>> >
>> > I know you are just refactoring code, but at some point it would be
>> > good to take a closer look at this MDIO bus driver.
>
>> And, to re-iterate all of your points are valid, but this is premature
>
> We agree then :-)
>
>    Andrew

I also agree with all of your points, but hope this is not something
that would prevent this patch series from being acceptable.  It could
be quite an effort to try and properly document the code and what it
is doing, get HW to verify the assumptions from the documentation (as
the MIPS HW was done by a different group, no hardware is available,
etc), relocate the code to the drivers/net/phy and add a standard
interface.  From your original comment, I believe that you agree that
this additional effort is not necessary at this point in time.

Thanks,
Jon

Thread

[RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-28 21:40 +0200
  Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a  separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-28 22:10 +0200
  Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a  separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 16:20 +0200
    Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a  separate file Florian Fainelli <f.fainelli@gmail.com> - 2016-06-29 20:40 +0200
      Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a  separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 20:50 +0200
        Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a  separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-29 22:10 +0200
          Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a  separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 22:20 +0200
            Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a  separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-29 22:40 +0200

csiph-web