Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

From	Jon Mason <jon.mason@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints
Date	2016-06-29 22:20 +0200
Message-ID	<rPu7M-go-9@gated-at.bofh.it> (permalink)
References	<rP71w-2K4-7@gated-at.bofh.it> <rP71x-2K4-53@gated-at.bofh.it> <rP7bb-2NB-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 28, 2016 at 3:43 PM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2016-06-28 at 15:34 -0400, Jon Mason wrote:
>> The bgmac_* print wrappers call dev_* prints with the dev pointer from
>> the bcma core.  In anticipation of removing the bcma requirement for
>> this driver, these must be changed to not reference that struct.  So,
>> simply change all of the bgmac_* prints to their dev_* counterparts.  In
>> some cases netdev_* prints are more appropriate, so change those as
>> well.
>
> Thanks, but...
>
>> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> []
>> @@ -1515,7 +1516,7 @@ static void bgmac_get_drvinfo(struct net_device *net_dev,
>>                             struct ethtool_drvinfo *info)
>>  {
>>       strlcpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
>> -     strlcpy(info->bus_info, "BCMA", sizeof(info->bus_info));
>> +     strlcpy(info->bus_info, "AXI", sizeof(info->bus_info));
>>  }
>
> Unrelated change?

This is a needed change, but unrelated to this patch.  I'll move it to
the 5/7 patch, where it more logically fits.

Thanks,
Jon

>

Thread

[RFC 0/7] net: ethernet: bgmac: Add platform device support Jon Mason <jon.mason@broadcom.com> - 2016-06-28 21:40 +0200
  [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints Jon Mason <jon.mason@broadcom.com> - 2016-06-28 21:40 +0200
    Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_*  prints Joe Perches <joe@perches.com> - 2016-06-28 21:50 +0200
      Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints Jon Mason <jon.mason@broadcom.com> - 2016-06-29 22:20 +0200
  Re: [RFC 0/7] net: ethernet: bgmac: Add platform device support Florian Fainelli <f.fainelli@gmail.com> - 2016-06-29 21:00 +0200

csiph-web