Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1433266
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file |
| Date | 2016-06-28 22:10 +0200 |
| Message-ID | <rP7ux-39z-13@gated-at.bofh.it> (permalink) |
| References | <rP71w-2K4-7@gated-at.bofh.it> <rP71w-2K4-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jun 28, 2016 at 03:34:40PM -0400, Jon Mason wrote:
> Move the BCMA MDIO phy into a separate file, as it is very tightly
> coupled with the BCMA bus. This will help with the upcoming BCMA
> removal from the bgmac driver. Optimally, this should be moved into
> phy drivers, but it is too tightly coupled with the bgmac driver to
> effectively move it without more changes to the driver.
It is quite common to have the MII bus driver as a sub driver of the
MAC driver, if they are tightly coupled. The MII drivers in
drivers/net/phy are all independent of the MAC driver and use a
different space in the register sets. This does not seem the case
here, so i think the split you have made is O.K, and i don't see a
need to move it into phy.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-28 21:40 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-28 22:10 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 16:20 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Florian Fainelli <f.fainelli@gmail.com> - 2016-06-29 20:40 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 20:50 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-29 22:10 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Andrew Lunn <andrew@lunn.ch> - 2016-06-29 22:20 +0200
Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason <jon.mason@broadcom.com> - 2016-06-29 22:40 +0200
csiph-web