Re: [PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious indentation issues

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious indentation issues
Date	2016-06-28 10:40 +0200
Message-ID	<rOWIN-4s2-9@gated-at.bofh.it> (permalink)
References	<rOVD3-3Lz-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 28, 2016 at 09:23:06AM +0200, Krzysztof Kozlowski wrote:
> The recently added test_mb_ahash_speed() has clearly serious coding
> style issues. Try to fix some of them:
> 1. Don't mix pr_err() and printk();
> 2. Don't wrap strings;
> 3. Properly align goto statement in if() block;
> 4. Align wrapped arguments on new line;
> 5. Don't wrap functions on first argument;
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious  indentation issues Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 09:30 +0200
  [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 09:30 +0200
    Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division  of s64 Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 10:50 +0200
      Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division  of s64 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 10:50 +0200
        crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed  test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 12:00 +0200
          Re: crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash  speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 13:20 +0200
            [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer  hash speed test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 14:40 +0200
              Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in  multibuffer hash speed test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-29 10:20 +0200
                Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in  multibuffer hash speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-29 10:30 +0200
                Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in  multibuffer hash speed test Megha Dey <megha.dey@linux.intel.com> - 2016-06-29 19:50 +0200
                crypto: tcrypt - Do not bail on EINPROGRESS in multibuffer hash test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-30 05:10 +0200
                Re: crypto: tcrypt - Do not bail on EINPROGRESS in multibuffer hash  test Megha Dey <megha.dey@linux.intel.com> - 2016-06-30 19:40 +0200
              Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in  multibuffer hash speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-29 10:20 +0200
  Re: [PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious  indentation issues Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 10:40 +0200

csiph-web