Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1433927

Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test

From Megha Dey <megha.dey@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test
Date 2016-06-29 19:50 +0200
Message-ID <rPrMB-79x-9@gated-at.bofh.it> (permalink)
References (5 earlier) <rOZdD-6hk-11@gated-at.bofh.it> <rP0t5-730-41@gated-at.bofh.it> <rPiT0-1Lg-21@gated-at.bofh.it> <rPiT0-1Lg-19@gated-at.bofh.it> <rPj2G-1OB-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


I tested the latest cryptodev tree on my haswell machine and this is
what I see:
[   40.402834] modprobe tcrypt mode=422
[   40.403105] testing speed of multibuffer sha1 (sha1_mb)
[   40.403108] test  0 (   16 byte blocks,   16 bytes per update,   1
updates):  32271 cycles/operation,  252 cycles/byte
[   40.403118] At least one hashing failed ret=-115
[   43.218712] modprobe tcrypt mode=423
[   43.218712] testing speed of multibuffer sha256 (sha256_mb)
[   43.218715] test  0 (   16 byte blocks,   16 bytes per update,   1
updates): 106965 cycles/operation,  835 cycles/byte
[   43.218747] At least one hashing failed ret=-115
[   45.346657] modprobe tcrypt mode=424
[   45.346657] testing speed of multibuffer sha512 (sha512_mb)
[   45.346660] test  0 (   16 byte blocks,   16 bytes per update,   1
updates):  43179 cycles/operation,  337 cycles/byte
[   45.346673] At least one hashing failed ret=-115

Don't think this is expected, is it?

This is the patch which might have an issue?
72259deb3a9f2c07d18d71d7c9356754e7d88369

Thanks,
Megha

On Wed, 2016-06-29 at 10:28 +0200, Krzysztof Kozlowski wrote:
> On 06/29/2016 10:19 AM, Herbert Xu wrote:
> > On Wed, Jun 29, 2016 at 10:16:10AM +0200, Krzysztof Kozlowski wrote:
> >>
> >> Seems to work fine except:
> >> 1. The updates are always 1.
> > 
> > Yes the test function only does digest so it's always one update.
> > 
> >> 2. For bigger blocks it reports always 1 or 3 cycles per byte:
> > 
> > Yes the average cycles per-byte should reach an asymptotic value.
> 
> Then:
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Best regards,
> Krzysztof
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious  indentation issues Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 09:30 +0200
  [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 09:30 +0200
    Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division  of s64 Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 10:50 +0200
      Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division  of s64 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 10:50 +0200
        crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed  test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 12:00 +0200
          Re: crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash  speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 13:20 +0200
            [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer  hash speed test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 14:40 +0200
              Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in  multibuffer hash speed test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-29 10:20 +0200
                Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in  multibuffer hash speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-29 10:30 +0200
                Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in  multibuffer hash speed test Megha Dey <megha.dey@linux.intel.com> - 2016-06-29 19:50 +0200
                crypto: tcrypt - Do not bail on EINPROGRESS in multibuffer hash test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-30 05:10 +0200
                Re: crypto: tcrypt - Do not bail on EINPROGRESS in multibuffer hash  test Megha Dey <megha.dey@linux.intel.com> - 2016-06-30 19:40 +0200
              Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in  multibuffer hash speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-29 10:20 +0200
  Re: [PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious  indentation issues Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 10:40 +0200

csiph-web