Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1432650
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 |
| Date | 2016-06-28 10:50 +0200 |
| Message-ID | <rOWSt-4vW-17@gated-at.bofh.it> (permalink) |
| References | <rOVD3-3Lz-3@gated-at.bofh.it> <rOVD4-3Lz-17@gated-at.bofh.it> <rOWSt-4vW-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/28/2016 10:41 AM, Herbert Xu wrote:
> On Tue, Jun 28, 2016 at 09:23:07AM +0200, Krzysztof Kozlowski wrote:
>> gcc 4.7.3 for ARM on Ubuntu couldn't link tcrypt module because of
>> division of s64:
>> ERROR: "__aeabi_ldivmod" [crypto/tcrypt.ko] undefined!
>>
>> Fixes: 087bcd225c56 ("crypto: tcrypt - Add speed tests for SHA multibuffer algorithms")
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> I'd prefer to be consistent here and just use unsigned long like
> every other speed test in tcrypt. This code has some serious
> issues, such as not waiting for completion in case of an error.
>
> Let me try to fix them up.
>
> Thanks!
>
> ---8<---
> Subject: crypto: tcrypt - Use unsigned long for mb ahash cycle counter
>
> For the timescales we are working against there is no need to
> go beyond unsigned long.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
Works fine for me:
Reported-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious indentation issues Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 09:30 +0200
[PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 09:30 +0200
Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 10:50 +0200
Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 10:50 +0200
crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 12:00 +0200
Re: crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-28 13:20 +0200
[PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 14:40 +0200
Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-29 10:20 +0200
Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-29 10:30 +0200
Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test Megha Dey <megha.dey@linux.intel.com> - 2016-06-29 19:50 +0200
crypto: tcrypt - Do not bail on EINPROGRESS in multibuffer hash test Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-30 05:10 +0200
Re: crypto: tcrypt - Do not bail on EINPROGRESS in multibuffer hash test Megha Dey <megha.dey@linux.intel.com> - 2016-06-30 19:40 +0200
Re: [PATCH v2] crypto: tcrypt - Fix memory leaks/crashes in multibuffer hash speed test Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-29 10:20 +0200
Re: [PATCH 1/2] crypto: tcrypt: Fix mixing printk/pr_err and obvious indentation issues Herbert Xu <herbert@gondor.apana.org.au> - 2016-06-28 10:40 +0200
csiph-web