Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1432634
| From | Antoine Tenart <antoine.tenart@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC |
| Date | 2016-06-28 10:40 +0200 |
| Message-ID | <rOWIN-4s2-7@gated-at.bofh.it> (permalink) |
| References | <rOWpr-4kK-23@gated-at.bofh.it> <rOWpr-4kK-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hello Quentin!
A few comments bellow:
On Tue, Jun 28, 2016 at 10:18:15AM +0200, Quentin Schulz wrote:
>
> diff --git a/drivers/mfd/sunxi-gpadc-mfd.c b/drivers/mfd/sunxi-gpadc-mfd.c
> new file mode 100644
> index 0000000..710e297
> --- /dev/null
> +++ b/drivers/mfd/sunxi-gpadc-mfd.c
> @@ -0,0 +1,188 @@
You should add a license statement here.
> +#include <linux/interrupt.h>
> +#include <linux/regmap.h>
> +#include <linux/mfd/sunxi-gpadc-mfd.h>
> +#include <linux/mfd/core.h>
> +#include <linux/of_device.h>
> +#include <linux/of_irq.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
Headers are usually included in the alphabetical order.
[...]
> diff --git a/include/linux/mfd/sunxi-gpadc-mfd.h b/include/linux/mfd/sunxi-gpadc-mfd.h
> new file mode 100644
> index 0000000..341f8c3
> --- /dev/null
> +++ b/include/linux/mfd/sunxi-gpadc-mfd.h
> @@ -0,0 +1,14 @@
You should also add a license statement here.
> +#ifndef __SUNXI_GPADC_MFD__H__
> +#define __SUNXI_GPADC_MFD__H__
> +
> +#define TP_INT_FIFOC 0x10
> +#define TP_INT_FIFOS 0x14
> +
> +struct sunxi_gpadc_mfd_dev {
> + void __iomem *regs;
> + struct device *dev;
> + struct regmap *regmap;
> + struct regmap_irq_chip_data *regmap_irqc;
> +};
> +
> +#endif
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] mfd: add support for Allwinner SoCs ADC Quentin Schulz <quentin.schulz@free-electrons.com> - 2016-06-28 10:20 +0200
Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-06-28 10:40 +0200
Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC Antoine Tenart <antoine.tenart@free-electrons.com> - 2016-06-28 11:00 +0200
Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC Jonathan Cameron <jic23@kernel.org> - 2016-07-03 13:20 +0200
Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC Lars-Peter Clausen <lars@metafoo.de> - 2016-07-03 19:00 +0200
Re: [PATCH 1/3] mfd: add support for Allwinner SoCs ADC Guenter Roeck <linux@roeck-us.net> - 2016-07-03 19:40 +0200
csiph-web