Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.

From	Joseph Myers <joseph@codesourcery.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.
Date	2016-06-22 12:40 +0200
Message-ID	<rMNJE-2bS-27@gated-at.bofh.it> (permalink)
References	<rMoBA-2OV-31@gated-at.bofh.it> <rMrJ7-53M-3@gated-at.bofh.it> <rMrJ7-53M-1@gated-at.bofh.it> <rML59-wN-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 22 Jun 2016, Yury Norov wrote:

> > As well as preprocessor indentation, this is missing spaces after '('; 
> > check for and fix that issue throughout this patch series.  (There are 
> > only a few cases where a macro is used to construct a type / variable 
> > name, such as ElfW, where missing the space is more usual.)
> > 
> > -- 
> > Joseph S. Myers
> > joseph@codesourcery.com
> 
> So, you want have it like this?
> #ifdef __LP64__
> # define RTLD_START RTLD_START_1( "x", "3", "sp" )

Sorry, before '(' in function and function-like-macro calls, as in 
standard GNU style.

# define RTLD_START RTLD_START_1 ("x", "3", "sp")

-- 
Joseph S. Myers
joseph@codesourcery.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Joseph Myers <joseph@codesourcery.com> - 2016-06-21 13:10 +0200
  Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Andreas Schwab <schwab@suse.de> - 2016-06-22 09:50 +0200
  Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Joseph Myers <joseph@codesourcery.com> - 2016-06-22 12:40 +0200

csiph-web