Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO
Date	2016-06-22 12:40 +0200
Message-ID	<rMNJE-2bS-29@gated-at.bofh.it> (permalink)
References	<rMLHQ-ZT-3@gated-at.bofh.it> <rMLHQ-ZT-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jun 22, 2016 at 05:25:53PM +0900, Alexandre Courbot wrote:
> The current regulator enable/disable mechanism does not call the driver
> enable/disable op if an enable GPIO is set. It may be desirable to use
> both mechanisms though, e.g. in the case of a PWM regulator that also
> has an enable GPIO.
> 
> _regulator_is_enabled() is also updated in order to take both enable
> conditions into account.

This is going to break or at least reduce the performance of a lot of
users - it is very common for regulators to have configurable support
for a GPIO enable in addition to a register enable with the GPIO enable
replacing a register enable for improved performance.  If you have some
strange device that requires GPIO and other operations the driver should
handle that, if nothing else it's likely that there are sequencing
requirements between the two which we are probably not going to get
right for everyone in the core.

Thread

[PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO Alexandre Courbot <acourbot@nvidia.com> - 2016-06-22 10:30 +0200
  Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op  and GPIO Mark Brown <broonie@kernel.org> - 2016-06-22 12:40 +0200
    Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op  and GPIO Alexandre Courbot <gnurou@gmail.com> - 2016-06-23 03:20 +0200
      Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op  and GPIO Alexandre Courbot <gnurou@gmail.com> - 2016-06-23 07:40 +0200
        Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op  and GPIO Mark Brown <broonie@kernel.org> - 2016-06-23 12:10 +0200

csiph-web