Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1428512
| From | Andreas Schwab <schwab@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. |
| Date | 2016-06-22 09:50 +0200 |
| Message-ID | <rML59-wN-41@gated-at.bofh.it> (permalink) |
| References | <rMoBA-2OV-31@gated-at.bofh.it> <rMrJ7-53M-3@gated-at.bofh.it> <rMrJ7-53M-1@gated-at.bofh.it> <rML59-wN-43@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Yury Norov <ynorov@caviumnetworks.com> writes:
> On Tue, Jun 21, 2016 at 10:28:40AM +0000, Joseph Myers wrote:
>> On Tue, 21 Jun 2016, Yury Norov wrote:
>>
>> > +#ifdef __LP64__
>> > +#define RTLD_START RTLD_START_1("x", "3", "sp")
>> > +#else
>> > +#define RTLD_START RTLD_START_1("w", "2", "wsp")
>> > +#endif
>>
>> As well as preprocessor indentation, this is missing spaces after '(';
Before, not after.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Joseph Myers <joseph@codesourcery.com> - 2016-06-21 13:10 +0200 Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Andreas Schwab <schwab@suse.de> - 2016-06-22 09:50 +0200 Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Joseph Myers <joseph@codesourcery.com> - 2016-06-22 12:40 +0200
csiph-web