Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1427609 > unrolled thread
| Started by | Joseph Myers <joseph@codesourcery.com> |
|---|---|
| First post | 2016-06-21 13:10 +0200 |
| Last post | 2016-06-22 12:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Joseph Myers <joseph@codesourcery.com> - 2016-06-21 13:10 +0200
Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Andreas Schwab <schwab@suse.de> - 2016-06-22 09:50 +0200
Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. Joseph Myers <joseph@codesourcery.com> - 2016-06-22 12:40 +0200
| From | Joseph Myers <joseph@codesourcery.com> |
|---|---|
| Date | 2016-06-21 13:10 +0200 |
| Subject | Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S. |
| Message-ID | <rMrJ7-53M-1@gated-at.bofh.it> |
On Tue, 21 Jun 2016, Yury Norov wrote:
> +#ifdef __LP64__
> +#define RTLD_START RTLD_START_1("x", "3", "sp")
> +#else
> +#define RTLD_START RTLD_START_1("w", "2", "wsp")
> +#endif
As well as preprocessor indentation, this is missing spaces after '(';
check for and fix that issue throughout this patch series. (There are
only a few cases where a macro is used to construct a type / variable
name, such as ElfW, where missing the space is more usual.)
--
Joseph S. Myers
joseph@codesourcery.com
[toc] | [next] | [standalone]
| From | Andreas Schwab <schwab@suse.de> |
|---|---|
| Date | 2016-06-22 09:50 +0200 |
| Message-ID | <rML59-wN-41@gated-at.bofh.it> |
| In reply to | #1427609 |
Yury Norov <ynorov@caviumnetworks.com> writes:
> On Tue, Jun 21, 2016 at 10:28:40AM +0000, Joseph Myers wrote:
>> On Tue, 21 Jun 2016, Yury Norov wrote:
>>
>> > +#ifdef __LP64__
>> > +#define RTLD_START RTLD_START_1("x", "3", "sp")
>> > +#else
>> > +#define RTLD_START RTLD_START_1("w", "2", "wsp")
>> > +#endif
>>
>> As well as preprocessor indentation, this is missing spaces after '(';
Before, not after.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
[toc] | [prev] | [next] | [standalone]
| From | Joseph Myers <joseph@codesourcery.com> |
|---|---|
| Date | 2016-06-22 12:40 +0200 |
| Message-ID | <rMNJE-2bS-27@gated-at.bofh.it> |
| In reply to | #1427609 |
On Wed, 22 Jun 2016, Yury Norov wrote:
> > As well as preprocessor indentation, this is missing spaces after '(';
> > check for and fix that issue throughout this patch series. (There are
> > only a few cases where a macro is used to construct a type / variable
> > name, such as ElfW, where missing the space is more usual.)
> >
> > --
> > Joseph S. Myers
> > joseph@codesourcery.com
>
> So, you want have it like this?
> #ifdef __LP64__
> # define RTLD_START RTLD_START_1( "x", "3", "sp" )
Sorry, before '(' in function and function-like-macro calls, as in
standard GNU style.
# define RTLD_START RTLD_START_1 ("x", "3", "sp")
--
Joseph S. Myers
joseph@codesourcery.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web