Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1420236
| From | Sakari Ailus <sakari.ailus@iki.fi> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] userspace API definitions for auto-focus coil |
| Date | 2016-06-12 13:30 +0200 |
| Message-ID | <rJbKy-825-17@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <rFIlH-2Qp-1@gated-at.bofh.it> <rGLAS-2kr-13@gated-at.bofh.it> <rGVTA-14x-1@gated-at.bofh.it> <rIZgl-hG-1@gated-at.bofh.it> <rJ9fH-6oM-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Pavel,
On Sun, Jun 12, 2016 at 10:48:11AM +0200, Pavel Machek wrote:
> Hi!
>
> > > >Add userspace API definitions.
> > > >
> > > >Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > >
> > > >diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> > > >index b6a357a..23011cc 100644
> > > >--- a/include/uapi/linux/v4l2-controls.h
> > > >+++ b/include/uapi/linux/v4l2-controls.h
> > > >@@ -974,4 +975,9 @@ enum v4l2_detect_md_mode {
> > > > #define V4L2_CID_DETECT_MD_THRESHOLD_GRID (V4L2_CID_DETECT_CLASS_BASE + 3)
> > > > #define V4L2_CID_DETECT_MD_REGION_GRID (V4L2_CID_DETECT_CLASS_BASE + 4)
> > > >
> > > >+/* Control IDs specific to the AD5820 driver as defined by V4L2 */
> > > >+#define V4L2_CID_FOCUS_AD5820_BASE (V4L2_CTRL_CLASS_CAMERA | 0x10af)
> >
> > Please check V4L2_CID_USER_*_BASE. That's how custom controls are handled
> > nowadays.
>
> So something like this?
>
> Thanks,
> Pavel
>
> diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
> index 2efa5dc1..b04b471 100644
> --- a/drivers/media/i2c/ad5820.c
> +++ b/drivers/media/i2c/ad5820.c
> @@ -40,6 +40,11 @@
> #define AD5820_RAMP_MODE_LINEAR (0 << 3)
> #define AD5820_RAMP_MODE_64_16 (1 << 3)
>
> +/* Control IDs specific to the AD5820 driver as defined by V4L2 */
> +#define V4L2_CID_FOCUS_AD5820_RAMP_TIME (V4L2_CID_USER_AD5820_BASE+0)
> +#define V4L2_CID_FOCUS_AD5820_RAMP_MODE (V4L2_CID_FOCUS_AD5820_BASE+1)
> +
> +
We could still define these in a header file that can be included by the
user space. Please use V4L2_CID_AD5820 prefix.
A separate header file should be used, e.g. include/uapi/linux/ad5820.h.
> #define CODE_TO_RAMP_US(s) ((s) == 0 ? 0 : (1 << ((s) - 1)) * 50)
> #define RAMP_US_TO_CODE(c) fls(((c) + ((c)>>1)) / 50)
>
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index 23011cc..4b24546 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -181,6 +181,10 @@ enum v4l2_colorfx {
> * We reserve 16 controls for this driver. */
> #define V4L2_CID_USER_TC358743_BASE (V4L2_CID_USER_BASE + 0x1080)
>
> +/* The base for the ad5820 driver controls.
> + * We reserve 16 controls for this driver. */
> +#define V4L2_CID_USER_AD5820_BASE (V4L2_CID_USER_BASE + 0x1090)
> +
> /* MPEG-class control IDs */
> /* The MPEG controls are applicable to all codec controls
> * and the 'MPEG' part of the define is historical */
> @@ -986,9 +990,4 @@ enum v4l2_detect_md_mode {
> #define V4L2_CID_MODE_SENSITIVITY (V4L2_CID_MODE_CLASS_BASE+6)
> #define V4L2_CID_MODE_OPSYSCLOCK (V4L2_CID_MODE_CLASS_BASE+7)
>
> -/* Control IDs specific to the AD5820 driver as defined by V4L2 */
> -#define V4L2_CID_FOCUS_AD5820_BASE (V4L2_CTRL_CLASS_CAMERA | 0x10af)
> -#define V4L2_CID_FOCUS_AD5820_RAMP_TIME (V4L2_CID_FOCUS_AD5820_BASE+0)
> -#define V4L2_CID_FOCUS_AD5820_RAMP_MODE (V4L2_CID_FOCUS_AD5820_BASE+1)
> -
> #endif
>
>
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCHv5] support for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-05-31 23:30 +0200
Re: [PATCHv5] support for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-05-31 23:40 +0200
Re: [PATCHv5] support for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-01 17:30 +0200
Re: [PATCHv5] support for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-02 00:10 +0200
Re: [PATCHv5] support for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-02 09:50 +0200
Re: [PATCHv5] support for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-02 21:30 +0200
Re: [PATCHv5] support for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-02 23:30 +0200
[PATCH] device tree description for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-02 21:40 +0200
Re: [PATCH] device tree description for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-02 23:30 +0200
Re: [PATCH] device tree description for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-03 08:20 +0200
[PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-05 21:10 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-06-06 08:10 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-06 09:30 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-12 00:10 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-12 10:00 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-17 23:30 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-12 10:50 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-12 13:30 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-13 21:20 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-17 23:40 +0200
[PATCHv4] support for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-18 17:40 +0200
Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-18 17:40 +0200
Re: [PATCH] device tree description for AD5820 camera auto-focus coil Rob Herring <robh@kernel.org> - 2016-06-06 15:30 +0200
[PATCHv2] device tree description for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-07 09:20 +0200
Re: [PATCHv2] device tree description for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-10 00:40 +0200
csiph-web