Re: [PATCH] userspace API definitions for auto-focus coil

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] userspace API definitions for auto-focus coil
Date	2016-06-18 17:40 +0200
Message-ID	<rLqvL-5Po-19@gated-at.bofh.it> (permalink)
References	(5 earlier) <rIZgl-hG-1@gated-at.bofh.it> <rJ9fH-6oM-3@gated-at.bofh.it> <rJbKy-825-17@gated-at.bofh.it> <rJFyX-26n-57@gated-at.bofh.it> <rL9EC-3tj-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi!

> > Not V4L2_CID_USER_AD5820...?
> 
> The rest of the controls have no USER as part of the macro name, so I
> wouldn't use it here either.

Ok.

> > Ok, separate header file for 2 lines seemed like a bit of overkill,
> > but why not.
> 
> That follows an existing pattern of how controls have been implemented in
> other drivers.

Ok.

> Could you merge this with the driver patch? I've dropped that from my ad5820
> branch as it does not compile.

Yes, merged patch should be in your inbox now.

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] userspace API definitions for auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-12 00:10 +0200
  Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-12 10:00 +0200
    Re: [PATCH] userspace API definitions for auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-17 23:30 +0200
  Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-12 10:50 +0200
    Re: [PATCH] userspace API definitions for auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-12 13:30 +0200
      Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-13 21:20 +0200
        Re: [PATCH] userspace API definitions for auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-17 23:40 +0200
          [PATCHv4] support for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-18 17:40 +0200
          Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-18 17:40 +0200

csiph-web