Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411318

Re: [PATCHv5] support for AD5820 camera auto-focus coil

Show all headers | View raw

Hi Pavel,

On Tue, May 31, 2016 at 11:34:37PM +0200, Pavel Machek wrote:
> On Wed 2016-06-01 00:22:22, Sakari Ailus wrote:
> > Hi Pavel,
> > 
> > On Fri, May 27, 2016 at 10:51:40PM +0200, Pavel Machek wrote:
> > > 
> > > This adds support for AD5820 autofocus coil, found for example in
> > > Nokia N900 smartphone.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > The patch looks good to me but then I came to think of a question I've
> > missed so far: is there DT documentation somewhere for the properties used
> > by the driver? I might put that to a separate patch, and cc the relevant
> > list.
> 
> Well, it does not use any dt properties. So there's not really much to
> discuss with dt people...
> 
> Maybe "ad5820" needs to go to list of simple i2c drivers somewhere,
> but...

It's an I2C device and it does use a regulator. Not a lot, though, these are
both quite basic stuff. This should still be documented as the people who
write the DT bindings (in general) aren't expected to read driver code as
well. That's at least my understanding.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv5] support for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-05-31 23:30 +0200
  Re: [PATCHv5] support for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-05-31 23:40 +0200
    Re: [PATCHv5] support for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-01 17:30 +0200
      Re: [PATCHv5] support for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-02 00:10 +0200
        Re: [PATCHv5] support for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-02 09:50 +0200
          Re: [PATCHv5] support for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-02 21:30 +0200
            Re: [PATCHv5] support for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-02 23:30 +0200
          [PATCH] device tree description for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-02 21:40 +0200
            Re: [PATCH] device tree description for AD5820 camera auto-focus coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-02 23:30 +0200
              Re: [PATCH] device tree description for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-03 08:20 +0200
              [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-05 21:10 +0200
                Re: [PATCH] userspace API definitions for auto-focus coil Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-06-06 08:10 +0200
                Re: [PATCH] userspace API definitions for auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-06 09:30 +0200
            Re: [PATCH] device tree description for AD5820 camera auto-focus coil Rob Herring <robh@kernel.org> - 2016-06-06 15:30 +0200
            [PATCHv2] device tree description for AD5820 camera auto-focus coil Pavel Machek <pavel@ucw.cz> - 2016-06-07 09:20 +0200
              Re: [PATCHv2] device tree description for AD5820 camera auto-focus  coil Sakari Ailus <sakari.ailus@iki.fi> - 2016-06-10 00:40 +0200

csiph-web