Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1415190
| From | <Mario_Limonciello@Dell.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD |
| Date | 2016-06-06 17:00 +0200 |
| Message-ID | <rH4au-6he-29@gated-at.bofh.it> (permalink) |
| References | <rH3xL-62c-11@gated-at.bofh.it> <rH3xM-62c-47@gated-at.bofh.it> <rH40P-6ct-71@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@lunn.ch]
> Sent: Monday, June 6, 2016 9:41 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: hayeswang@realtek.com; LKML <linux-kernel@vger.kernel.org>; Netdev
> <netdev@vger.kernel.org>; Linux USB <linux-usb@vger.kernel.org>;
> pali.rohar@gmail.com; anthony.wong@canonical.com; Greg KH
> <gregkh@linuxfoundation.org>
> Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC
> address on RTL8153-AD
>
> > + /* returns _AUXMAC_#AABBCCDDEEFF# */
> > + status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer);
> > + obj = (union acpi_object *)buffer.pointer;
> > + if (ACPI_SUCCESS(status)) {
> > + if (obj->type != ACPI_TYPE_BUFFER ||
> > + obj->string.length != 0x17) {
> > + pr_warn("r8152: get_passthru_addr: Invalid buffer");
>
> Please don't use pr_warn() when you can use the better alternatives
> like dev_warn().
>
> Andrew
OK thanks, I'll adjust that to use a different warn.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello <mario_limonciello@dell.com> - 2016-06-06 16:20 +0200
[PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello <mario_limonciello@dell.com> - 2016-06-06 16:20 +0200
Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 16:50 +0200
RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 18:20 +0200
RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 19:30 +0200
Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 19:40 +0200
Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Andrew Lunn <andrew@lunn.ch> - 2016-06-06 16:50 +0200
RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 16:50 +0200
RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 16:50 +0200
RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 17:00 +0200
csiph-web