Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415317

RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

From <Mario_Limonciello@Dell.com>
Newsgroups linux.kernel
Subject RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD
Date 2016-06-06 19:30 +0200
Message-ID <rH6vF-7U4-51@gated-at.bofh.it> (permalink)
References <rH3xL-62c-11@gated-at.bofh.it> <rH3xM-62c-47@gated-at.bofh.it> <rH40O-6ct-13@gated-at.bofh.it> <rH4au-6he-27@gated-at.bofh.it> <rH5pT-7hl-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

> > Realtek has this in their Windows driver that all OEM's will be taking.
> > Another OEM would just need to burn the right information into the SPI at
> > manufacturing and expose it to the DSDT.
> 
> Where it the match up for the Realtek bit to corrispond with this
> specific ACPI field?  If it's not in the ACPI spec, then vendors _WILL_
> do this in different ways.
> 
> Again, document it, in the code, what is going on here, that's all I'm
> asking.  I'm not asking you to change the logic at all!

I've added additional comments for v4.  I strongly believe that even if
another vendor does do this differently for their implementation of
\\_SB.AMAC this code will be safe to run.

All of the output from the field are tested for exactly what the field
should look like.

That said, I would be highly surprised if Realtek decided to implement
with another OEM differently.  It would increase their code complexity
on Windows as well since this is part of the generic driver.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello <mario_limonciello@dell.com> - 2016-06-06 16:20 +0200
  [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello <mario_limonciello@dell.com> - 2016-06-06 16:20 +0200
    Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 16:50 +0200
      RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
        Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 18:20 +0200
          RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 19:30 +0200
            Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 19:40 +0200
    Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Andrew Lunn <andrew@lunn.ch> - 2016-06-06 16:50 +0200
      RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
  Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 16:50 +0200
    RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 16:50 +0200
      RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
      Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 17:00 +0200

csiph-web