Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415189

Re: [PATCH] perf test: Ignore .scale and other special files

Show all headers | View raw

Em Mon, Jun 06, 2016 at 07:36:06AM -0700, Andi Kleen escreveu:
> perf test tries to parse all entries in /sys/devices/cpu/events/.
> Ignore the special entries like '.scale', which cannot be directly
> parsed as an event. This patch assumes all files containing a '.'
> are special and can be ignored.

> +++ b/tools/perf/tests/parse-events.c
> @@ -1783,8 +1783,8 @@ static int test_pmu_events(void)
> -		if (!strcmp(ent->d_name, ".") ||
> -		    !strcmp(ent->d_name, ".."))
> +		/* Names containing . are special and cannot be used directly */
> +		if (strchr(ent->d_name, '.'))
>  			continue;

Ok, this is a more generic fix than the one I used here (adding: ||
strends(ent->d_name, ".scale"), I'll use yours, but this gets us to the
following error:

[root@jouet ~]# perf test -v 5 2>&1 | tail
running test 49 'r1234/name=rawpmu/'
running test 50 '4:0x6530160/name=numpmu/'
running test 51 'L1-dcache-misses/name=cachepmu/'
running test 0 'cpu/config=10,config1,config2=3,period=1000/u'
running test 1 'cpu/config=1,name=krava/u,cpu/config=2/u'
running test 2 'cpu/config=1,call-graph=fp,time,period=100000/,cpu/config=2,call-graph=no,time=0,period=2000/'
failed to parse event 'topdown-total-slots:u,cpu/event=topdown-total-slots/u', err 1
test child finished with 1
---- end ----
parse events tests: FAILED!
[root@jouet ~]# cat /sys/devices/cpu/events/topdown-total-slots
event=0x3c,umask=0x0,any=1[root@jouet ~]# 
[root@jouet ~]# 
[root@jouet ~]# cat /sys/devices/cpu/events/bus-cycles 
event=0x3c,umask=0x01
[root@jouet ~]# 

I.e seems to be bickering about a missing newline in the sysfs entry, will check the parser...

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf test: Ignore .scale and other special files Andi Kleen <andi@firstfloor.org> - 2016-06-06 16:40 +0200
  Re: [PATCH] perf test: Ignore .scale and other special files Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 17:00 +0200
    Re: [PATCH] perf test: Ignore .scale and other special files Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 17:20 +0200
      Re: [PATCH] perf test: Ignore .scale and other special files Andi Kleen <ak@linux.intel.com> - 2016-06-06 18:40 +0200
        Re: [PATCH] perf test: Ignore .scale and other special files Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 22:00 +0200
  Re: [PATCH] perf test: Ignore .scale and other special files Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-06 17:00 +0200
  [tip:perf/core] perf test: Ignore .scale and other special files tip-bot for Andi Kleen <tipbot@zytor.com> - 2016-06-08 10:40 +0200

csiph-web