Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415181

RE: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

Show all headers | View raw

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Monday, June 6, 2016 9:40 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: hayeswang@realtek.com; LKML <linux-kernel@vger.kernel.org>; Netdev
> <netdev@vger.kernel.org>; Linux USB <linux-usb@vger.kernel.org>;
> pali.rohar@gmail.com; anthony.wong@canonical.com
> Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC
> address on RTL8153-AD
> 
> On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote:
> > Since this is a Realtek feature, I feel this shouldn't be moved into a platform
> > MAC address lookup.  The code should only be run when the correct
> Realtek device
> > is plugged in.
> >
> > Changes from v2:
> >  * Only apply to RTL8153-AD w/ eFuse pass through mac address pass thru
> >    bit set.
> >  * Drop matching DMI information on Dell.  Although this is implemented
> on
> >    Dell, this is a Realtek feature that may may be implemented on other
> >    OEMs as well.
> >  * Test that pass through MAC address is valid, fall back to HW address if
> >    invalid.
> >  * Don't track status of which device has MAC pass through activated.
> >  - Expected experience is that if two docks (RTL8153-AD's w/ mac pass thru
> >    bit set) were plugged in both should have MAC pass through activated.
> 
> cover letters for single-patch submissions is overkill and confusing,
> please don't.

I was trying to convey differences between versions of this patch, I'll avoid
that in the future and let the audience find them themselves.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello <mario_limonciello@dell.com> - 2016-06-06 16:20 +0200
  [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD Mario Limonciello <mario_limonciello@dell.com> - 2016-06-06 16:20 +0200
    Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 16:50 +0200
      RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
        Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 18:20 +0200
          RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 19:30 +0200
            Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 19:40 +0200
    Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Andrew Lunn <andrew@lunn.ch> - 2016-06-06 16:50 +0200
      RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
  Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 16:50 +0200
    RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 16:50 +0200
      RE: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD <Mario_Limonciello@Dell.com> - 2016-06-06 17:00 +0200
      Re: [PATCH v3] r8152: Add support for setting pass through MAC  address on RTL8153-AD Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 17:00 +0200

csiph-web