Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1332663

Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build
Date Fri, 12 Feb 2016 11:40:02 +0100
Message-ID <r1jiO-5IA-1@gated-at.bofh.it> (permalink)
References <r11Ff-2lT-5@gated-at.bofh.it> <r11Ff-2lT-7@gated-at.bofh.it> <r1imK-54w-21@gated-at.bofh.it> <r1iPM-5vL-11@gated-at.bofh.it>
X-Original-To Arnd Bergmann <arnd@arndb.de>
X-Nifty-Srcip [209.85.161.171]
X-Gm-Message-State AG10YOSsXtlsfGkPLzoUILXNwnXmXFpp0yJNJ81fnaXsyWHa/q5j/njoxxIhv+wcaPT5XV4kOLWmdpZ3a+3MOQ==
MIME-Version 1.0
X-Received by 10.13.253.198 with SMTP id n189mr432953ywf.46.1455273522866; Fri, 12 Feb 2016 02:38:42 -0800 (PST)
X-Gmail-Original-Message-ID <CAK7LNATEhZuqkMaEONu7tDBzWnTqS527c0N0vuOKRJuPeeQSDA@mail.gmail.com>
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 40
Organization linux.* mail to news gateway
X-Original-Cc linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Paul Gortmaker <paul.gortmaker@windriver.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>
X-Original-Date Fri, 12 Feb 2016 19:38:42 +0900
X-Original-Message-ID <CAK7LNATEhZuqkMaEONu7tDBzWnTqS527c0N0vuOKRJuPeeQSDA@mail.gmail.com>
X-Original-References <1455205297-1021302-1-git-send-email-arnd@arndb.de> <1455205297-1021302-5-git-send-email-arnd@arndb.de> <CAK7LNAR8fJWPubucjw28gAPpF-4yvVMWZZ0F3j6VN4whGF9Yhw@mail.gmail.com> <3557175.oOjJgCHd2P@wuerfel>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1332663

Show key headers only | View raw


Hi Arnd,


2016-02-12 19:07 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Friday 12 February 2016 18:37:08 Masahiro Yamada wrote:
>> >  };
>> >
>> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
>> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>> >  static int __init uniphier_early_console_setup(struct earlycon_device *device,
>> >                                                const char *options)
>> >  {
>> > --
>> > 2.7.0
>> >
>>
>> I noticed commit 2eaa790989e03900298ad24f77f1086dbbc1aebd
>> revived this link error, but I am not happy with seeing
>> this patch again and again.
>>
>>
>> Can you check this patch?
>> https://patchwork.kernel.org/patch/8289231/
>>
>>
>>
>
> Yes, I think your patch is nicer than mine. Let's see what the others
> think, then I can resend my remaining patches on top of yours.

OK, thanks!

I noticed some typos, so I've posted v2.
(no change in code-diff).



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann <arnd@arndb.de> - 2016-02-11 16:50 +0100
  Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 10:40 +0100
    Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann <arnd@arndb.de> - 2016-02-12 11:10 +0100
      Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 11:40 +0100
      Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 17:40 +0100

csiph-web