Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1332654

Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build
Date 2016-02-12 11:10 +0100
Message-ID <r1iPM-5vL-11@gated-at.bofh.it> (permalink)
References <r11Ff-2lT-5@gated-at.bofh.it> <r11Ff-2lT-7@gated-at.bofh.it> <r1imK-54w-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Friday 12 February 2016 18:37:08 Masahiro Yamada wrote:
> >  };
> >
> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
> >  static int __init uniphier_early_console_setup(struct earlycon_device *device,
> >                                                const char *options)
> >  {
> > --
> > 2.7.0
> >
> 
> I noticed commit 2eaa790989e03900298ad24f77f1086dbbc1aebd
> revived this link error, but I am not happy with seeing
> this patch again and again.
> 
> 
> Can you check this patch?
> https://patchwork.kernel.org/patch/8289231/
> 
> 
> 

Yes, I think your patch is nicer than mine. Let's see what the others
think, then I can resend my remaining patches on top of yours.

	Arnd

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann <arnd@arndb.de> - 2016-02-11 16:50 +0100
  Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 10:40 +0100
    Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann <arnd@arndb.de> - 2016-02-12 11:10 +0100
      Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 11:40 +0100
      Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 17:40 +0100

csiph-web