Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1332619

Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build

Show all headers | View raw

Hi Arnd,




2016-02-12 0:41 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The newly added uniphier serial port driver fails to build as
> a loadable module when the base 8250 driver is built-in and
> its console support enabled:
>
> ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>
> This changes the driver to only provide the early console support
> if it is built-in itself as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/tty/serial/8250/8250_uniphier.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
> index bab6b3ae2540..1b7bd26555b7 100644
> --- a/drivers/tty/serial/8250/8250_uniphier.c
> +++ b/drivers/tty/serial/8250/8250_uniphier.c
> @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>         spinlock_t atomic_write_lock;
>  };
>
> -#ifdef CONFIG_SERIAL_8250_CONSOLE
> +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>  static int __init uniphier_early_console_setup(struct earlycon_device *device,
>                                                const char *options)
>  {
> --
> 2.7.0
>

I noticed commit 2eaa790989e03900298ad24f77f1086dbbc1aebd
revived this link error, but I am not happy with seeing
this patch again and again.


Can you check this patch?
https://patchwork.kernel.org/patch/8289231/



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann <arnd@arndb.de> - 2016-02-11 16:50 +0100
  Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 10:40 +0100
    Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann <arnd@arndb.de> - 2016-02-12 11:10 +0100
      Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 11:40 +0100
      Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 17:40 +0100

csiph-web