[PATCH v2 4/6] serial: 8250/uniphier: fix modular build

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH v2 4/6] serial: 8250/uniphier: fix modular build
Date	2016-02-11 16:50 +0100
Message-ID	<r11Ff-2lT-7@gated-at.bofh.it> (permalink)
References	<r11Ff-2lT-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The newly added uniphier serial port driver fails to build as
a loadable module when the base 8250 driver is built-in and
its console support enabled:

ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!

This changes the driver to only provide the early console support
if it is built-in itself as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/tty/serial/8250/8250_uniphier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
index bab6b3ae2540..1b7bd26555b7 100644
--- a/drivers/tty/serial/8250/8250_uniphier.c
+++ b/drivers/tty/serial/8250/8250_uniphier.c
@@ -35,7 +35,7 @@ struct uniphier8250_priv {
 	spinlock_t atomic_write_lock;
 };
 
-#ifdef CONFIG_SERIAL_8250_CONSOLE
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
 static int __init uniphier_early_console_setup(struct earlycon_device *device,
 					       const char *options)
 {
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann <arnd@arndb.de> - 2016-02-11 16:50 +0100
  Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 10:40 +0100
    Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Arnd Bergmann <arnd@arndb.de> - 2016-02-12 11:10 +0100
      Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 11:40 +0100
      Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-12 17:40 +0100

csiph-web