Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool

From	David Rientjes <rientjes@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool
Date	2015-11-16 11:10 +0100
Message-ID	<qvoTw-5Zc-9@gated-at.bofh.it> (permalink)
References	<qvlVD-3Sn-3@gated-at.bofh.it> <qvlVF-3Sn-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 16 Nov 2015, Yaowei Bai wrote:

> diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> index 6523109..1da03f5 100644
> --- a/include/linux/gfp.h
> +++ b/include/linux/gfp.h
> @@ -375,12 +375,9 @@ static inline enum zone_type gfp_zone(gfp_t flags)
>   * virtual kernel addresses to the allocated page(s).
>   */
>  
> -static inline int gfp_zonelist(gfp_t flags)
> +static inline bool gfp_zonelist(gfp_t flags)
>  {
> -	if (IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE))
> -		return 1;
> -
> -	return 0;
> +	return IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE);
>  }
>  
>  /*

This function is used to index into a pgdat's node_zonelists[] array, bool 
makes no sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/7] some small improvement Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-16 08:00 +0100
  [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-16 08:00 +0100
    Re: [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean David Rientjes <rientjes@google.com> - 2015-11-16 11:20 +0100
      Re: [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-17 03:20 +0100
  [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-16 08:00 +0100
    Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool David Rientjes <rientjes@google.com> - 2015-11-16 11:10 +0100
      Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-17 03:10 +0100
        Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool David Rientjes <rientjes@google.com> - 2015-11-17 06:50 +0100
          Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-17 09:40 +0100
  [PATCH] mm/zonelist: enumerate zonelists array index Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-17 10:10 +0100
  [PATCH] mm/mmzone: memmap_valid_within can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-18 02:40 +0100

csiph-web