Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270767

Re: [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean

Show all headers | View raw

On Mon, Nov 16, 2015 at 02:10:10AM -0800, David Rientjes wrote:
> On Mon, 16 Nov 2015, Yaowei Bai wrote:
> 
> > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h
> > index cf55945..af73135 100644
> > --- a/include/linux/mm_inline.h
> > +++ b/include/linux/mm_inline.h
> > @@ -8,8 +8,8 @@
> >   * page_is_file_cache - should the page be on a file LRU or anon LRU?
> >   * @page: the page to test
> >   *
> > - * Returns 1 if @page is page cache page backed by a regular filesystem,
> > - * or 0 if @page is anonymous, tmpfs or otherwise ram or swap backed.
> > + * Returns true if @page is page cache page backed by a regular filesystem,
> > + * or false if @page is anonymous, tmpfs or otherwise ram or swap backed.
> >   * Used by functions that manipulate the LRU lists, to sort a page
> >   * onto the right LRU list.
> >   *
> > @@ -17,7 +17,7 @@
> >   * needs to survive until the page is last deleted from the LRU, which
> >   * could be as far down as __page_cache_release.
> >   */
> > -static inline int page_is_file_cache(struct page *page)
> > +static inline bool page_is_file_cache(struct page *page)
> >  {
> >  	return !PageSwapBacked(page);
> >  }
> 
> Since page_is_file_cache() is often used to determine which zlc to 
> increment or decrement (usage such as 
> NR_ISOLATED_ANON + page_is_file_cache(page)), I don't think this style is 
> helpful.

Yes, you'r right, we can drop this one.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean Yaowei Bai <baiyaowei@cmss.chinamobile.com> - 2015-11-17 03:20 +0100

csiph-web