Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1240518

Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks

Show all headers | View raw

Hi Marcin,
 
 On mar., oct. 06 2015, Marcin Wojtas <mw@semihalf.com> wrote:

> In case of armada_38x_quirks error, all clocks should be cleaned-up, same
> as after mv_conf_mbus_windows failure.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Cc: <stable@vger.kernel.org> # v4.2

Good catch.

Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory

> ---
>  drivers/mmc/host/sdhci-pxav3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 89a9e49..f5edf9d 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -402,7 +402,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>  	if (of_device_is_compatible(np, "marvell,armada-380-sdhci")) {
>  		ret = armada_38x_quirks(pdev, host);
>  		if (ret < 0)
> -			goto err_clk_get;
> +			goto err_mbus_win;
>  		ret = mv_conf_mbus_windows(pdev, mv_mbus_dram_info());
>  		if (ret < 0)
>  			goto err_mbus_win;
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 17:00 +0200
      Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-06 17:10 +0200
    Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 03:20 +0200
      Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-09 11:50 +0200
  [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 16:50 +0200
  [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 17:00 +0200
    Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Ulf Hansson <ulf.hansson@linaro.org> - 2015-10-08 19:40 +0200
      Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Marcin Wojtas <mw@semihalf.com> - 2015-10-09 02:50 +0200
  [PATCH 8/8] mmc: sdhci-pxav3: enable modifying MMC_CARD bit during card initialization Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  [PATCH 7/8] mmc: sdhci: add init_card callback to sdhci Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 16:50 +0200
    Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-06 17:50 +0200
      Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-08 15:30 +0200

csiph-web