Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243196

Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC

Show all headers | View raw

Hi Jisheng,


>> +     res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mbus");
>> +     pxa->mbus_win_regs = devm_ioremap_resource(&pdev->dev, res);
>> +     if (IS_ERR(pxa->mbus_win_regs)) {
>> +             dev_err(mmc_dev(host->mmc),
>> +                     "failed to obtain MBus windows register base\n");
>
> devm_ioremap_resource() has warned us if it fails, so is it better to remove
> this dev_err() here?
>

Indeed, I'll remove this excessive verbosity.

>>       struct sdhci_host *host = dev_get_drvdata(dev);
>> +     struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>> +     struct sdhci_pxa *pxa = pltfm_host->priv;
>> +     struct device_node *np = dev->of_node;
>> +
>> +     if (of_device_is_compatible(np, "marvell,armada-380-sdhci"))
>
> this would increase resume time especially those non armada-380-sdhci host
> although it's trivial. Is it better to check "if (pxa->mbus_win_regs)"?
>

Already implemented in v2.

Thanks for the comments,
Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 17:00 +0200
      Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-06 17:10 +0200
    Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 03:20 +0200
      Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-09 11:50 +0200
  [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 16:50 +0200
  [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 17:00 +0200
    Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Ulf Hansson <ulf.hansson@linaro.org> - 2015-10-08 19:40 +0200
      Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Marcin Wojtas <mw@semihalf.com> - 2015-10-09 02:50 +0200
  [PATCH 8/8] mmc: sdhci-pxav3: enable modifying MMC_CARD bit during card initialization Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  [PATCH 7/8] mmc: sdhci: add init_card callback to sdhci Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 16:50 +0200
    Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-06 17:50 +0200
      Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-08 15:30 +0200

csiph-web