Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1240497

Re: [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards

Show all headers | View raw

Hi Marcin,
 
 On mar., oct. 06 2015, Marcin Wojtas <mw@semihalf.com> wrote:

> From: Nadav Haklai <nadavh@marvell.com>
>
> According to 'FE-2946959' erratum the clock inversion option is
> needed to support slow frequencies when the card input hold time
> requirement is high. This setting is not required for high speed
> MMC and might cause timing violation.
>
> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
> Cc: <stable@vger.kernel.org> # v4.2

Seems OK too.

Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory
> ---
>  drivers/mmc/host/sdhci-pxav3.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 976cddd..89a9e49 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -291,6 +291,9 @@ static void pxav3_set_uhs_signaling(struct sdhci_host *host, unsigned int uhs)
>  		    uhs == MMC_TIMING_UHS_DDR50) {
>  			reg_val &= ~SDIO3_CONF_CLK_INV;
>  			reg_val |= SDIO3_CONF_SD_FB_CLK;
> +		} else if (uhs == MMC_TIMING_MMC_HS) {
> +			reg_val &= ~SDIO3_CONF_CLK_INV;
> +			reg_val &= ~SDIO3_CONF_SD_FB_CLK;
>  		} else {
>  			reg_val |= SDIO3_CONF_CLK_INV;
>  			reg_val &= ~SDIO3_CONF_SD_FB_CLK;
> -- 
> 1.8.3.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 17:00 +0200
      Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-06 17:10 +0200
    Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Jisheng Zhang <jszhang@marvell.com> - 2015-10-09 03:20 +0200
      Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada  38x SoC Marcin Wojtas <mw@semihalf.com> - 2015-10-09 11:50 +0200
  [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 16:50 +0200
  [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
    Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 17:00 +0200
    Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Ulf Hansson <ulf.hansson@linaro.org> - 2015-10-08 19:40 +0200
      Re: [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Marcin Wojtas <mw@semihalf.com> - 2015-10-09 02:50 +0200
  [PATCH 8/8] mmc: sdhci-pxav3: enable modifying MMC_CARD bit during card initialization Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  [PATCH 7/8] mmc: sdhci: add init_card callback to sdhci Marcin Wojtas <mw@semihalf.com> - 2015-10-06 03:20 +0200
  Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Gregory CLEMENT <gregory.clement@free-electrons.com> - 2015-10-06 16:50 +0200
    Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-06 17:50 +0200
      Re: [PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas <mw@semihalf.com> - 2015-10-08 15:30 +0200

csiph-web