Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1240517

RE: [f2fs-dev] [PATCH 3/3] f2fs: introduce a periodic checkpoint flow

Show all headers | View raw

Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Tuesday, October 06, 2015 6:44 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 3/3] f2fs: introduce a periodic checkpoint flow
> 
> This patch introduces a periodic checkpoint feature.
> Note that, this is not enforcing to conduct checkpoints very strictly in terms
> of trigger timing, instead just hope to help user experiences.
> The default value is 60 seconds.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Looks good to me except one minor thing that it's better to add a cp_expires
initialization.

Please append all patches of patch set with:
Reviewed-by: Chao Yu <chao2.yu@samsung.com>

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] f2fs: introduce a periodic checkpoint flow Jaegeuk Kim <jaegeuk@kernel.org> - 2015-10-06 00:50 +0200
  RE: [f2fs-dev] [PATCH 3/3] f2fs: introduce a periodic checkpoint flow Chao Yu <yuchaochina@hotmail.com> - 2015-10-06 17:00 +0200
    Re: [f2fs-dev] [PATCH 3/3] f2fs: introduce a periodic checkpoint flow Jaegeuk Kim <jaegeuk@kernel.org> - 2015-10-07 01:30 +0200

csiph-web