Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap
Date	2015-09-21 22:00 +0200
Message-ID	<qbfpN-85w-27@gated-at.bofh.it> (permalink)
References	(1 earlier) <q92Gn-3AZ-31@gated-at.bofh.it> <qaAPE-JA-21@gated-at.bofh.it> <qbcrV-3RU-35@gated-at.bofh.it> <qbeWK-7xn-19@gated-at.bofh.it> <qbfg6-7Up-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Sep 21, 2015 at 02:46:50PM -0500, Andrew F. Davis wrote:
> On 09/21/2015 02:26 PM, Mark Brown wrote:

> >So split that interface change between the MFD and the function drivers
> >out into a separate change - you've got way more than just an interface
> >change in here (and you've not enumerated the various things that are
> >being changed in the changelog).

> I'm not really "changing" anything, this is a ground-up re-write. This
> fundamentally changes the way the MFD core and the function drivers interact,
> I would consider this a whole new driver that just happens to replace an older
> driver, not a bunch of incremental changes although I kept the same filenames.

So split out the deletion then add the new driver like you'd add any
other new driver.  If there were in tree users even that would be really
problematic but it does seem like we don't have any so perhaps people
will be OK with this.

Thread

[PATCH 0/3] mfd: tps65912: Driver rewrite with DT support "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
  [PATCH 1/3] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
    Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the  TPS65912 PMIC Lee Jones <lee.jones@linaro.org> - 2015-09-20 06:20 +0200
      Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the  TPS65912 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-09-21 18:40 +0200
        Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the  TPS65912 PMIC Lee Jones <lee.jones@linaro.org> - 2015-09-22 01:10 +0200
          Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the  TPS65912 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-09-22 22:00 +0200
  [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration dependencies "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
    Re: [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration  dependencies Mark Brown <broonie@kernel.org> - 2015-09-16 22:00 +0200
    Re: [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration dependencies Linus Walleij <linus.walleij@linaro.org> - 2015-10-02 12:30 +0200
  Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
    Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 18:50 +0200
      Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap Mark Brown <broonie@kernel.org> - 2015-09-21 21:30 +0200
        Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 21:50 +0200
          Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap Mark Brown <broonie@kernel.org> - 2015-09-21 22:00 +0200
            Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 22:10 +0200
  Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap Lee Jones <lee.jones@linaro.org> - 2015-09-22 01:10 +0200

csiph-web