Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1228798
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap |
| Date | 2015-09-20 02:40 +0200 |
| Message-ID | <qaAPE-JA-21@gated-at.bofh.it> (permalink) |
| References | <q92Gm-3AZ-5@gated-at.bofh.it> <q92Gn-3AZ-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Sep 15, 2015 at 12:57:40PM -0500, Andrew F. Davis wrote: > The old driver does not support DT. Rewrite the driver adding DT support > and use modern kernel features such as regmap and related helpers. > > Signed-off-by: Andrew F. Davis <afd@ti.com> > --- > drivers/gpio/gpio-tps65912.c | 291 ++++++------ > drivers/mfd/Kconfig | 20 +- > drivers/mfd/Makefile | 3 +- > drivers/mfd/tps65912-core.c | 288 +++++------- > drivers/mfd/tps65912-i2c.c | 233 ++++------ > drivers/mfd/tps65912-irq.c | 217 --------- > drivers/mfd/tps65912-spi.c | 236 ++++------ > drivers/regulator/tps65912-regulator.c | 783 ++++++++++----------------------- > include/linux/mfd/tps65912.h | 256 +++++++---- > 9 files changed, 854 insertions(+), 1473 deletions(-) It's not OK to have a single commit that rewrites multiple drivers over many subsystems, that's really not something that can be sensibly reviewed. You should split this into a patch series which makes one specific change at a time as covered in SubmittingPatches. That will allow the changes to be reviewed much more sensibly.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] mfd: tps65912: Driver rewrite with DT support "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
[PATCH 1/3] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC Lee Jones <lee.jones@linaro.org> - 2015-09-20 06:20 +0200
Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-09-21 18:40 +0200
Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC Lee Jones <lee.jones@linaro.org> - 2015-09-22 01:10 +0200
[PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration dependencies "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
Re: [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration dependencies Mark Brown <broonie@kernel.org> - 2015-09-16 22:00 +0200
Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 18:50 +0200
Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap Mark Brown <broonie@kernel.org> - 2015-09-21 21:30 +0200
Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 21:50 +0200
Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap Mark Brown <broonie@kernel.org> - 2015-09-21 22:00 +0200
Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 22:10 +0200
Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap Lee Jones <lee.jones@linaro.org> - 2015-09-22 01:10 +0200
csiph-web