Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1229706

Re: [Open-FCoE] [PATCH] fcoe:Fix incorrect use of non wrapper version of skb_buff helper function in fcoe_percpu_recieve_thread

Show all headers | View raw

On Sun, Sep 20, 2015 at 06:22:39PM -0400, Nicholas Krause wrote:
> This fixes the incorrect use of the non wrapper version of the
> function skb_dequeue in fcoe_percpu_receive_thread to use the
> wrapper version as we need to protect avoid other users from
> concurrently access on the sk_buff_head tmp used as the link
> list head for this call to skb_queue.

The sk_buff_head tmp is a local reference on the stack, so not accessed
concurrently from anywhere.  It's set with skb_queue_splice_init while
holding the lock for the real fcoe_rx_list, specifically to batch
process without repeatedly taking and dropping the lock.

Nak, flawed reasoning for justification.

- Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Open-FCoE] [PATCH] fcoe:Fix incorrect use of non wrapper  version of skb_buff helper function in fcoe_percpu_recieve_thread Chris Leech <cleech@redhat.com> - 2015-09-21 22:10 +0200

csiph-web