Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1229699

Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap

Show all headers | View raw

On 09/21/2015 02:26 PM, Mark Brown wrote:
> On Mon, Sep 21, 2015 at 11:42:13AM -0500, Andrew F. Davis wrote:
>
>> I know this is hard to review, and so I would like to apologize in advance, but
>> the regulator and GPIO changes depend on the new driver core, as do the i2c/spi
>> components. I really don't know how to split this up without leaving some part
>> in a non-working state in-between patches (which I've heard is also not OK).
>
> So split that interface change between the MFD and the function drivers
> out into a separate change - you've got way more than just an interface
> change in here (and you've not enumerated the various things that are
> being changed in the changelog).
>

I'm not really "changing" anything, this is a ground-up re-write. This
fundamentally changes the way the MFD core and the function drivers interact,
I would consider this a whole new driver that just happens to replace an older
driver, not a bunch of incremental changes although I kept the same filenames.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] mfd: tps65912: Driver rewrite with DT support "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
  [PATCH 1/3] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
    Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the  TPS65912 PMIC Lee Jones <lee.jones@linaro.org> - 2015-09-20 06:20 +0200
      Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the  TPS65912 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-09-21 18:40 +0200
        Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the  TPS65912 PMIC Lee Jones <lee.jones@linaro.org> - 2015-09-22 01:10 +0200
          Re: [PATCH 1/3] Documentation: tps65912: Add DT bindings for the  TPS65912 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-09-22 22:00 +0200
  [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration dependencies "Andrew F. Davis" <afd@ti.com> - 2015-09-15 20:00 +0200
    Re: [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration  dependencies Mark Brown <broonie@kernel.org> - 2015-09-16 22:00 +0200
    Re: [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration dependencies Linus Walleij <linus.walleij@linaro.org> - 2015-10-02 12:30 +0200
  Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap Mark Brown <broonie@kernel.org> - 2015-09-20 02:40 +0200
    Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 18:50 +0200
      Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap Mark Brown <broonie@kernel.org> - 2015-09-21 21:30 +0200
        Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 21:50 +0200
          Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap Mark Brown <broonie@kernel.org> - 2015-09-21 22:00 +0200
            Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap "Andrew F. Davis" <afd@ti.com> - 2015-09-21 22:10 +0200
  Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and  using regmap Lee Jones <lee.jones@linaro.org> - 2015-09-22 01:10 +0200

csiph-web