Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1320587

Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator
Date Thu, 28 Jan 2016 12:40:02 +0100
Message-ID <qVT5E-2Js-11@gated-at.bofh.it> (permalink)
References <qVx59-3fC-15@gated-at.bofh.it> <qVx59-3fC-13@gated-at.bofh.it> <qVzzY-4VL-9@gated-at.bofh.it> <qVP22-8nH-9@gated-at.bofh.it>
X-Original-To Henry Chen <henryc.chen@mediatek.com>
MIME-Version 1.0
Content-Type multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh"
Content-Disposition inline
X-Cookie Be careful! UGLY strikes 9 out of 10!
User-Agent Mutt/1.5.24 (2015-08-30)
X-Sa-Exim-Connect-IP 94.175.94.161
X-Sa-Exim-Mail-From broonie@sirena.org.uk
X-Sa-Exim-Version 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned Yes (on mezzanine.sirena.org.uk)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 40
Organization linux.* mail to news gateway
X-Original-Cc John Crispin <blogic@openwrt.org>, Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, Chen Zhong <chen.zhong@mediatek.com>, linux-arm-kernel@lists.infradead.org
X-Original-Date Thu, 28 Jan 2016 11:38:40 +0000
X-Original-Message-ID <20160128113840.GA6078@sirena.org.uk>
X-Original-References <1453896059-44589-1-git-send-email-blogic@openwrt.org> <1453896059-44589-2-git-send-email-blogic@openwrt.org> <20160127144105.GQ6042@sirena.org.uk> <1453965401.19407.18.camel@mtksdaap41>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1320587

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Jan 28, 2016 at 03:16:41PM +0800, Henry Chen wrote:
> On Wed, 2016-01-27 at 14:41 +0000, Mark Brown wrote:

> > No, drivers should *never* enable things that weren't explictly enabled
> > by the machine constraints.  This misses the whole point of having
> > constraints.  They are there so that the system integrator can enable
> > the functionality that is safe on a given board.  

> Okay..the constrains should be define on device tree.
> But which optional properties was suitable to fill on device tree if consumers want to call
> regulator_set_mode directly ?
> I have check the of_regulator.c and not found the suitable property name which can set valid_modes_mask & valid_ops_mask.

If you need to change the mode at runtime you will need to develop a
binding for that, there isn't one at present.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Henry Chen <henryc.chen@mediatek.com> - 2016-01-28 08:20 +0100
  Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-28 12:40 +0100

csiph-web