Groups > linux.kernel > #1320588

Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver
Date	2016-01-28 12:40 +0100
Message-ID	<qVT5E-2Js-15@gated-at.bofh.it> (permalink)
References	<qPJLI-2jg-13@gated-at.bofh.it> <qPJLI-2jg-27@gated-at.bofh.it> <qUQjw-5hx-17@gated-at.bofh.it> <qVRnd-1sZ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 28 Jan 2016, chenfeng wrote:

> Hi Lee,
> 
> Thanks for your review!
> There is one things need your confirm.
> Please help to see it below.
> 
> On 2016/1/25 22:22, Lee Jones wrote:
> > On Mon, 11 Jan 2016, Chen Feng wrote:
> > 
> >> Add pmic mfd driver to support hisilicon hi665x.
> [..]
> 
> > 
> >> +static const struct mfd_cell hi655x_pmic_devs[] = {
> >> +	{ .name = "hi655x-regulator", },
> >> +};
> > 
> > What other devices are there?
> > 
> 
> Current the MFD PMIC driver only has regulator enable.
> 
> The RTC & Power-key are not in these patch sets.
> 
> They will be added later.
> 
> Will this be accepted?

Yes.

> >> +static const struct regmap_irq hi655x_irqs[] = {
> >> +	{ .reg_offset = 0, .mask = OTMP_D1R_INT },
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver chenfeng <puck.chen@hisilicon.com> - 2016-01-28 10:50 +0100
  Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver Lee Jones <lee.jones@linaro.org> - 2016-01-28 12:40 +0100

csiph-web