Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1320587

Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator
Date 2016-01-28 12:40 +0100
Message-ID <qVT5E-2Js-11@gated-at.bofh.it> (permalink)
References <qVx59-3fC-15@gated-at.bofh.it> <qVx59-3fC-13@gated-at.bofh.it> <qVzzY-4VL-9@gated-at.bofh.it> <qVP22-8nH-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Jan 28, 2016 at 03:16:41PM +0800, Henry Chen wrote:
> On Wed, 2016-01-27 at 14:41 +0000, Mark Brown wrote:

> > No, drivers should *never* enable things that weren't explictly enabled
> > by the machine constraints.  This misses the whole point of having
> > constraints.  They are there so that the system integrator can enable
> > the functionality that is safe on a given board.  

> Okay..the constrains should be define on device tree.
> But which optional properties was suitable to fill on device tree if consumers want to call
> regulator_set_mode directly ?
> I have check the of_regulator.c and not found the suitable property name which can set valid_modes_mask & valid_ops_mask.

If you need to change the mode at runtime you will need to develop a
binding for that, there isn't one at present.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Henry Chen <henryc.chen@mediatek.com> - 2016-01-28 08:20 +0100
  Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-28 12:40 +0100

csiph-web