Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320358

Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator

Show all headers | View raw

Hi Mark,

On Wed, 2016-01-27 at 14:41 +0000, Mark Brown wrote:
> On Wed, Jan 27, 2016 at 01:00:59PM +0100, John Crispin wrote:
> 
> > +		/* Constrain board-specific capabilities according to what
> > +		 * this driver and the chip itself can actually do.
> > +		 */
> > +		c = rdev->constraints;
> > +		c->valid_modes_mask |= REGULATOR_MODE_NORMAL |
> > +				       REGULATOR_MODE_STANDBY;
> > +		c->valid_ops_mask |= REGULATOR_CHANGE_MODE;
> 
> No, drivers should *never* enable things that weren't explictly enabled
> by the machine constraints.  This misses the whole point of having
> constraints.  They are there so that the system integrator can enable
> the functionality that is safe on a given board.  

Okay..the constrains should be define on device tree.
But which optional properties was suitable to fill on device tree if consumers want to call
regulator_set_mode directly ?
I have check the of_regulator.c and not found the suitable property name which can set valid_modes_mask & valid_ops_mask.

Thanks,
Henry 
> 
> The comment is also inaccurate, it claims it's imposing constraints but
> in fact it's adding additional permissions.
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator John Crispin <blogic@openwrt.org> - 2016-01-27 13:10 +0100
  Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-27 15:50 +0100
    Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Henry Chen <henryc.chen@mediatek.com> - 2016-01-28 08:20 +0100
      Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-28 12:40 +0100
    Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator John Crispin <blogic@openwrt.org> - 2016-01-28 19:20 +0100
      Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-29 00:20 +0100
        Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-01-29 11:00 +0100
          Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-01-29 12:30 +0100
            Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-01-29 13:20 +0100
              Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-02 20:40 +0100
              Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-02 20:40 +0100
                Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-02-03 06:40 +0100
                Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator Mark Brown <broonie@kernel.org> - 2016-02-03 13:40 +0100
                Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323  regulator menghui lin <menghui.lin@mediatek.com> - 2016-02-04 03:50 +0100

csiph-web