Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320378

Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2)

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2)
Date 2016-01-28 09:20 +0100
Message-ID <qVPY6-AA-7@gated-at.bofh.it> (permalink)
References <qVAw1-5GW-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 28, 2016 at 12:40:47AM +0900, Namhyung Kim wrote:
> Hello,
> 
> This patchset tries to implement percent limit to callchains which was
> requested by Andi Kleen.  For some reason, limiting callchains by
> (overhead) percentage didn't work well.  This patch fixes it and make
> --percent-limit also works for callchains as well as hist entries.
> 
>  * Changes from v1)
>   - fix insertion path instead of changing all UI code
>   - show percent value even on single path (if needed)
>   - change default callchain percent limit
>   
> This is available on 'perf/callchain-limit-v2' branch in my tree:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> Any comments are welcome,
> 
> Thanks,
> Namhyung
> *** BLURB HERE ***
> 
> Namhyung Kim (10):
>   perf hists: Fix min callchain hits calculation
>   perf hists: Update hists' total period when adding entries
>   perf report: Apply --percent-limit to callchains also
>   perf report: Get rid of hist_entry__callchain_fprintf()
>   perf tools: Pass parent_samples to __callchain__fprintf_graph()
>   perf report: Fix percent display in callchains on --stdio
>   perf hists browser: Fix dump to show correct callchain style
>   perf hists browser: Pass parent_total to callchain print functions
>   perf hists browser: Fix percent display in callchains
>   perf tools: Change default calchain percent limit to 0.005%

heya,
do I get it right that:

'perf report' display all entries, but only callchains above default limit

'perf report --percent-limit X' display only entries above limit X plus
only callchains above limit X


thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-27 16:50 +0100
  [PATCH 07/10] perf hists browser: Fix dump to show correct callchain style Namhyung Kim <namhyung@kernel.org> - 2016-01-27 16:50 +0100
    [tip:perf/core] perf hists browser:   Fix dump to show correct callchain style tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100
  [PATCH 09/10] perf hists browser: Fix percent display in callchains Namhyung Kim <namhyung@kernel.org> - 2016-01-27 16:50 +0100
    [tip:perf/core] perf hists browser:   Fix percent display in callchains tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100
  [PATCH 04/10] perf report: Get rid of hist_entry__callchain_fprintf() Namhyung Kim <namhyung@kernel.org> - 2016-01-27 16:50 +0100
    [tip:perf/core] perf report:   Get rid of hist_entry__callchain_fprintf() tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100
  [PATCH 01/10] perf hists: Fix min callchain hits calculation Namhyung Kim <namhyung@kernel.org> - 2016-01-27 16:50 +0100
    [tip:perf/core] perf hists: Fix min callchain hits calculation tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100
  [PATCH 03/10] perf report: Apply --percent-limit to callchains also Namhyung Kim <namhyung@kernel.org> - 2016-01-27 16:50 +0100
    Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-01 21:20 +0100
      Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Namhyung Kim <namhyung@kernel.org> - 2016-02-02 14:10 +0100
        Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 15:00 +0100
          Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Namhyung Kim <namhyung@kernel.org> - 2016-02-02 15:20 +0100
            Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 15:30 +0100
              Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Namhyung Kim <namhyung@kernel.org> - 2016-02-02 15:40 +0100
                Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 16:00 +0100
                Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Namhyung Kim <namhyung@kernel.org> - 2016-02-02 16:10 +0100
    [tip:perf/core] perf report:   Apply --percent-limit to callchains also tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100
  [PATCH 06/10] perf report: Fix percent display in callchains on --stdio Namhyung Kim <namhyung@kernel.org> - 2016-01-27 16:50 +0100
    [tip:perf/core] perf report:   Fix percent display in callchains on --stdio tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100
  [RFC/PATCH 10/10] perf tools: Change default calchain percent limit to 0.005% Namhyung Kim <namhyung@kernel.org> - 2016-01-27 16:50 +0100
    Re: [RFC/PATCH 10/10] perf tools: Change default calchain percent  limit to 0.005% Andi Kleen <andi@firstfloor.org> - 2016-01-27 17:10 +0100
      Re: [RFC/PATCH 10/10] perf tools: Change default calchain percent  limit to 0.005% Namhyung Kim <namhyung@kernel.org> - 2016-01-28 00:40 +0100
  Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 09:20 +0100
    Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@gmail.com> - 2016-01-28 09:50 +0100
  Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 09:20 +0100
    Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 11:20 +0100
      Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 11:20 +0100
        Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 13:20 +0100
          Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 13:30 +0100
            Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 21:00 +0100
              Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-29 22:10 +0100
                Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-30 15:00 +0100
            [tip:perf/core] perf report: Don'  t show blank lines if entry has no callchain tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100

csiph-web