Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2)

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2)
Date	2016-01-30 15:00 +0100
Message-ID	<qWEef-3Qn-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <qVRQe-1UP-19@gated-at.bofh.it> <qVTIm-3eg-9@gated-at.bofh.it> <qVTS2-3iP-25@gated-at.bofh.it> <qW0Tx-8hX-21@gated-at.bofh.it> <qWosP-BF-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arnaldo,

On Sat, Jan 30, 2016 at 6:00 AM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> Em Thu, Jan 28, 2016 at 08:52:25PM +0100, Jiri Olsa escreveu:
>> On Thu, Jan 28, 2016 at 09:24:54PM +0900, Namhyung Kim wrote:
>>
>> SNIP
>>
>> > > > > The default limit of hist entries is 0 so it basically shows all
>> > > > > entries.  But default callchain limit is 0.5% so hist entries under
>> > > > > 0.5% won't show callchains.
>> > > >
>> > > > Btw, I changed it to 0.005% in this patchset.  Did you apply all the
>> > > > patches and run 'perf report' with default value?
>> > >
>> > > yep, I had it and then reverted ;-) but I made typo
>> > > in the previous email.. what I meant was:
>> > >
>> > > also I see extra LINE for entries...  ;-)
>> >
>> > Ah, so you meant the blank lines..  The fix would be like following
>>
>> yep, tested.. works ;-)
>
> Namhyung, can I try to process this patchkit just by reading these
> commends and making the adjustments? Or is there something outstanding
> that warrants you to push a v2?

It'd great for me if you process this (v1).  I cannot work on the v2
for a couple of days..

Thanks,
Namhyung

Thread

Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 09:20 +0100
  Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 11:20 +0100
    Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 11:20 +0100
      Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 13:20 +0100
        Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 13:30 +0100
          Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 21:00 +0100
            Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-29 22:10 +0100
              Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-30 15:00 +0100
          [tip:perf/core] perf report: Don'  t show blank lines if entry has no callchain tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100

csiph-web