Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1325157

[tip:perf/core] perf report: Don' t show blank lines if entry has no callchain

Show all headers | View raw

Commit-ID:  3848c23b19e07188bfa15e3d9a2ac27692f2ff3c
Gitweb:     http://git.kernel.org/tip/3848c23b19e07188bfa15e3d9a2ac27692f2ff3c
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Thu, 28 Jan 2016 21:24:54 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 1 Feb 2016 17:51:09 -0300

perf report: Don't show blank lines if entry has no callchain

When all callchains of a hist entry is percent-limited, do not add a
blank line at the end.  It makes the entry look like it doesn't have
callchains.

Reported-and-Tested-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20160128122454.GA27446@danjae.kornet
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/ui/stdio/hist.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
index 76ff46b..691e52c 100644
--- a/tools/perf/ui/stdio/hist.c
+++ b/tools/perf/ui/stdio/hist.c
@@ -233,7 +233,10 @@ static size_t callchain__fprintf_graph(FILE *fp, struct rb_root *root,
 
 	ret += __callchain__fprintf_graph(fp, root, total_samples,
 					  1, 1, left_margin);
-	ret += fprintf(fp, "\n");
+	if (ret) {
+		/* do not add a blank line if it printed nothing */
+		ret += fprintf(fp, "\n");
+	}
 
 	return ret;
 }

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 09:20 +0100
  Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 11:20 +0100
    Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 11:20 +0100
      Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 13:20 +0100
        Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-28 13:30 +0100
          Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Jiri Olsa <jolsa@redhat.com> - 2016-01-28 21:00 +0100
            Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains  (v2) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-29 22:10 +0100
              Re: [PATCHSET 00/10] perf tools: Apply percent-limit to callchains (v2) Namhyung Kim <namhyung@kernel.org> - 2016-01-30 15:00 +0100
          [tip:perf/core] perf report: Don'  t show blank lines if entry has no callchain tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-03 11:30 +0100

csiph-web