Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains also

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains also
Date	2016-02-01 21:20 +0100
Message-ID	<qXt73-89b-7@gated-at.bofh.it> (permalink)
References	<qVAw1-5GW-3@gated-at.bofh.it> <qVAw3-5GW-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Thu, Jan 28, 2016 at 12:40:50AM +0900, Namhyung Kim escreveu:
> Currently --percent-limit option only works for hist entries.  However
> it'd be better to have same effect to callchains as well

Documentation needs updating? It says:

--percent-limit::
        Do not show entries which have an overhead under that percent.
        (Default: 0).

 
> Requested-by: Andi Kleen <andi@firstfloor.org>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-report.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 2bf537f190a0..72ed0b46d5a1 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -75,7 +75,10 @@ static int report__config(const char *var, const char *value, void *cb)
>  		return 0;
>  	}
>  	if (!strcmp(var, "report.percent-limit")) {
> -		rep->min_percent = strtof(value, NULL);
> +		double pcnt = strtof(value, NULL);
> +
> +		rep->min_percent = pcnt;
> +		callchain_param.min_percent = pcnt;
>  		return 0;
>  	}
>  	if (!strcmp(var, "report.children")) {
> @@ -633,8 +636,10 @@ parse_percent_limit(const struct option *opt, const char *str,
>  		    int unset __maybe_unused)
>  {
>  	struct report *rep = opt->value;
> +	double pcnt = strtof(str, NULL);
>  
> -	rep->min_percent = strtof(str, NULL);
> +	rep->min_percent = pcnt;
> +	callchain_param.min_percent = pcnt;
>  	return 0;
>  }
>  
> -- 
> 2.6.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-01 21:20 +0100
  Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Namhyung Kim <namhyung@kernel.org> - 2016-02-02 14:10 +0100
    Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 15:00 +0100
      Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Namhyung Kim <namhyung@kernel.org> - 2016-02-02 15:20 +0100
        Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 15:30 +0100
          Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Namhyung Kim <namhyung@kernel.org> - 2016-02-02 15:40 +0100
            Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 16:00 +0100
              Re: [PATCH 03/10] perf report: Apply --percent-limit to callchains  also Namhyung Kim <namhyung@kernel.org> - 2016-02-02 16:10 +0100

csiph-web