Groups > linux.kernel > #1320211

Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"

Path	csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Kefeng Wang <wangkefeng.wang@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"
Date	Thu, 28 Jan 2016 02:50:01 +0100
Message-ID	<qVJSF-4fP-13@gated-at.bofh.it> (permalink)
References	<qVpTX-6np-5@gated-at.bofh.it> <qVq3E-6sp-7@gated-at.bofh.it> <qVyDT-4eI-1@gated-at.bofh.it>
X-Original-To	Masahiro Yamada <yamada.masahiro@socionext.com>
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.177.19.180]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020205.56A971CF.0152,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	3a643570b2480a2d43c5c987a08725bd
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>, Russell King <linux@arm.linux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, Hauke Mehrtens <hauke@hauke-m.de>, Rob Herring <robh+dt@kernel.org>, <guohanjun@huawei.com>
X-Original-Date	Thu, 28 Jan 2016 09:41:23 +0800
X-Original-Message-ID	<56A971C3.6000608@huawei.com>
X-Original-References	<1453868872-26300-1-git-send-email-wangkefeng.wang@huawei.com> <1453868872-26300-15-git-send-email-wangkefeng.wang@huawei.com> <CAK7LNAR=E5kYzsO9=YDeAVzp9cLWd9C8ANeVGJOvM=BSM4aTjg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1320211

Show key headers only | View raw

Hi Masahiro,

On 2016/1/27 21:48, Masahiro Yamada wrote:
> 2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>:
>> This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782.
>>
>> After covering to use helper of_platform_default_populate() to
>> populate the default bus, no error in build uniphier driver as
>> a module.
> 
> This statement is weird.
> There is no error for building this driver as a module
> at the point of v4.5-rc1.

Yes, but after drop export of_default_bus_match_table in patchset(15/15),
we will meet build issue, so the statement can be changed to
------------
After covering to use helper of_platform_default_populate() to
populate the default bus, this driver can be safely as a tristate
one, no error in build uniphier driver as a module once we drop
export of_default_bus_match_table in later patch.
------------
> 
> The of_platform_default_populate() conversion (11/15) is unrelated
> to fixing the build error.
> 
> BTW, I had already posted an equivalent patch a few days before:
> 
> https://patchwork.kernel.org/patch/8096991/
> 
I didn't notice this before, it is ok for me to use your patch, or I will send
a new one with update changlog, thanks for your review.

> 
> 
> 
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  drivers/bus/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
>> index 129d47b..9a92c07 100644
>> --- a/drivers/bus/Kconfig
>> +++ b/drivers/bus/Kconfig
>> @@ -132,7 +132,7 @@ config SUNXI_RSB
>>           and AC100/AC200 ICs.
>>
>>  config UNIPHIER_SYSTEM_BUS
>> -       bool "UniPhier System Bus driver"
>> +       tristate "UniPhier System Bus driver"
>>         depends on ARCH_UNIPHIER && OF
>>         default y
>>         help
>> --
>> 2.6.0.GIT
>>
> 
>

Thread

[PATCH 00/15] use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 03/15] mips: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 03/15] mips: use of_platform_default_populate() to  populate default bus Joshua Henderson <joshua.henderson@microchip.com> - 2016-01-29 17:00 +0100
      Re: [PATCH 03/15] mips: use of_platform_default_populate() to  populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-30 04:00 +0100
  [PATCH 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 01/15] arm: use of_platform_default_populate() to  populate default bus kbuild test robot <lkp@intel.com> - 2016-01-27 08:10 +0100
      Re: [PATCH 01/15] arm: use of_platform_default_populate() to populate  default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 09:00 +0100
    [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 09:00 +0100
      Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to  populate default bus Shawn Guo <shawnguo@kernel.org> - 2016-02-01 15:00 +0100
      Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus Heiko Stübner <heiko@sntech.de> - 2016-02-01 15:30 +0100
  [PATCH 12/15] memory: omap-gpmc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 08/15] nios2: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 13/15] of: unittest: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 05/15] c6x: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
  [PATCH 02/15] arm64: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 02/15] arm64: use of_platform_default_populate() to  populate default bus Catalin Marinas <catalin.marinas@arm.com> - 2016-01-27 11:40 +0100
  [PATCH 04/15] arc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 04/15] arc: use of_platform_default_populate() to  populate default bus Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-27 09:00 +0100
  [PATCH 06/15] metag: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    Re: [PATCH 06/15] metag: use of_platform_default_populate() to  populate default bus James Hogan <james.hogan@imgtec.com> - 2016-01-27 12:40 +0100
  Re: [PATCH 09/15] xtensa: use of_platform_default_populate() to  populate default bus Max Filippov <jcmvbkbc@gmail.com> - 2016-01-27 05:40 +0100
  [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
    Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-27 14:50 +0100
      Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-28 02:50 +0100
  [PATCH 07/15] cris: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
  [PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
  [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
    Re: [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate()  to populate default bus Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-27 14:50 +0100

csiph-web