Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320211
| From | Kefeng Wang <wangkefeng.wang@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" |
| Date | 2016-01-28 02:50 +0100 |
| Message-ID | <qVJSF-4fP-13@gated-at.bofh.it> (permalink) |
| References | <qVpTX-6np-5@gated-at.bofh.it> <qVq3E-6sp-7@gated-at.bofh.it> <qVyDT-4eI-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Masahiro, On 2016/1/27 21:48, Masahiro Yamada wrote: > 2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>: >> This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782. >> >> After covering to use helper of_platform_default_populate() to >> populate the default bus, no error in build uniphier driver as >> a module. > > This statement is weird. > There is no error for building this driver as a module > at the point of v4.5-rc1. Yes, but after drop export of_default_bus_match_table in patchset(15/15), we will meet build issue, so the statement can be changed to ------------ After covering to use helper of_platform_default_populate() to populate the default bus, this driver can be safely as a tristate one, no error in build uniphier driver as a module once we drop export of_default_bus_match_table in later patch. ------------ > > The of_platform_default_populate() conversion (11/15) is unrelated > to fixing the build error. > > BTW, I had already posted an equivalent patch a few days before: > > https://patchwork.kernel.org/patch/8096991/ > I didn't notice this before, it is ok for me to use your patch, or I will send a new one with update changlog, thanks for your review. > > > >> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >> Cc: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> >> --- >> drivers/bus/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig >> index 129d47b..9a92c07 100644 >> --- a/drivers/bus/Kconfig >> +++ b/drivers/bus/Kconfig >> @@ -132,7 +132,7 @@ config SUNXI_RSB >> and AC100/AC200 ICs. >> >> config UNIPHIER_SYSTEM_BUS >> - bool "UniPhier System Bus driver" >> + tristate "UniPhier System Bus driver" >> depends on ARCH_UNIPHIER && OF >> default y >> help >> -- >> 2.6.0.GIT >> > >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/15] use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
[PATCH 03/15] mips: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
Re: [PATCH 03/15] mips: use of_platform_default_populate() to populate default bus Joshua Henderson <joshua.henderson@microchip.com> - 2016-01-29 17:00 +0100
Re: [PATCH 03/15] mips: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-30 04:00 +0100
[PATCH 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
Re: [PATCH 01/15] arm: use of_platform_default_populate() to populate default bus kbuild test robot <lkp@intel.com> - 2016-01-27 08:10 +0100
Re: [PATCH 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 09:00 +0100
[PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 09:00 +0100
Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus Shawn Guo <shawnguo@kernel.org> - 2016-02-01 15:00 +0100
Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus Heiko Stübner <heiko@sntech.de> - 2016-02-01 15:30 +0100
[PATCH 12/15] memory: omap-gpmc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
[PATCH 08/15] nios2: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
[PATCH 13/15] of: unittest: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
[PATCH 05/15] c6x: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
[PATCH 02/15] arm64: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
Re: [PATCH 02/15] arm64: use of_platform_default_populate() to populate default bus Catalin Marinas <catalin.marinas@arm.com> - 2016-01-27 11:40 +0100
[PATCH 04/15] arc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
Re: [PATCH 04/15] arc: use of_platform_default_populate() to populate default bus Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-27 09:00 +0100
[PATCH 06/15] metag: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
Re: [PATCH 06/15] metag: use of_platform_default_populate() to populate default bus James Hogan <james.hogan@imgtec.com> - 2016-01-27 12:40 +0100
Re: [PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus Max Filippov <jcmvbkbc@gmail.com> - 2016-01-27 05:40 +0100
[PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-27 14:50 +0100
Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-28 02:50 +0100
[PATCH 07/15] cris: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
[PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
[PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
Re: [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-27 14:50 +0100
csiph-web