Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318606 > unrolled thread

[PATCH 00/15] use of_platform_default_populate() to populate default bus

Started byKefeng Wang <wangkefeng.wang@huawei.com>
First post2016-01-27 05:30 +0100
Last post2016-01-27 14:50 +0100
Articles 8 on this page of 28 — 10 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/15] use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    [PATCH 03/15] mips: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
      Re: [PATCH 03/15] mips: use of_platform_default_populate() to  populate default bus Joshua Henderson <joshua.henderson@microchip.com> - 2016-01-29 17:00 +0100
        Re: [PATCH 03/15] mips: use of_platform_default_populate() to  populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-30 04:00 +0100
    [PATCH 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
      Re: [PATCH 01/15] arm: use of_platform_default_populate() to  populate default bus kbuild test robot <lkp@intel.com> - 2016-01-27 08:10 +0100
        Re: [PATCH 01/15] arm: use of_platform_default_populate() to populate  default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 09:00 +0100
      [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 09:00 +0100
        Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to  populate default bus Shawn Guo <shawnguo@kernel.org> - 2016-02-01 15:00 +0100
        Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus Heiko Stübner <heiko@sntech.de> - 2016-02-01 15:30 +0100
    [PATCH 12/15] memory: omap-gpmc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    [PATCH 08/15] nios2: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    [PATCH 13/15] of: unittest: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    [PATCH 05/15] c6x: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
    [PATCH 02/15] arm64: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
      Re: [PATCH 02/15] arm64: use of_platform_default_populate() to  populate default bus Catalin Marinas <catalin.marinas@arm.com> - 2016-01-27 11:40 +0100
    [PATCH 04/15] arc: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
      Re: [PATCH 04/15] arc: use of_platform_default_populate() to  populate default bus Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-27 09:00 +0100
    [PATCH 06/15] metag: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:30 +0100
      Re: [PATCH 06/15] metag: use of_platform_default_populate() to  populate default bus James Hogan <james.hogan@imgtec.com> - 2016-01-27 12:40 +0100
    Re: [PATCH 09/15] xtensa: use of_platform_default_populate() to  populate default bus Max Filippov <jcmvbkbc@gmail.com> - 2016-01-27 05:40 +0100
    [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
      Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-27 14:50 +0100
        Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver" Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-28 02:50 +0100
    [PATCH 07/15] cris: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
    [PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
    [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-01-27 05:40 +0100
      Re: [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate()  to populate default bus Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-27 14:50 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1318619 — Re: [PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus

FromMax Filippov <jcmvbkbc@gmail.com>
Date2016-01-27 05:40 +0100
SubjectRe: [PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus
Message-ID<qVq3D-6sp-1@gated-at.bofh.it>
In reply to#1318606
On Wed, Jan 27, 2016 at 7:27 AM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  arch/xtensa/kernel/setup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max

[toc] | [prev] | [next] | [standalone]

#1318622 — [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"

FromKefeng Wang <wangkefeng.wang@huawei.com>
Date2016-01-27 05:40 +0100
Subject[PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"
Message-ID<qVq3E-6sp-7@gated-at.bofh.it>
In reply to#1318606
This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782.

After covering to use helper of_platform_default_populate() to
populate the default bus, no error in build uniphier driver as
a module.

Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/bus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 129d47b..9a92c07 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -132,7 +132,7 @@ config SUNXI_RSB
 	  and AC100/AC200 ICs.
 
 config UNIPHIER_SYSTEM_BUS
-	bool "UniPhier System Bus driver"
+	tristate "UniPhier System Bus driver"
 	depends on ARCH_UNIPHIER && OF
 	default y
 	help
-- 
2.6.0.GIT

[toc] | [prev] | [next] | [standalone]

#1318963 — Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-01-27 14:50 +0100
SubjectRe: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"
Message-ID<qVyDT-4eI-1@gated-at.bofh.it>
In reply to#1318622
2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>:
> This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782.
>
> After covering to use helper of_platform_default_populate() to
> populate the default bus, no error in build uniphier driver as
> a module.

This statement is weird.
There is no error for building this driver as a module
at the point of v4.5-rc1.

The of_platform_default_populate() conversion (11/15) is unrelated
to fixing the build error.

BTW, I had already posted an equivalent patch a few days before:

https://patchwork.kernel.org/patch/8096991/




> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/bus/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 129d47b..9a92c07 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -132,7 +132,7 @@ config SUNXI_RSB
>           and AC100/AC200 ICs.
>
>  config UNIPHIER_SYSTEM_BUS
> -       bool "UniPhier System Bus driver"
> +       tristate "UniPhier System Bus driver"
>         depends on ARCH_UNIPHIER && OF
>         default y
>         help
> --
> 2.6.0.GIT
>


-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#1320211 — Re: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"

FromKefeng Wang <wangkefeng.wang@huawei.com>
Date2016-01-28 02:50 +0100
SubjectRe: [PATCH 14/15] Revert "bus: uniphier: allow only built-in driver"
Message-ID<qVJSF-4fP-13@gated-at.bofh.it>
In reply to#1318963
Hi Masahiro,

On 2016/1/27 21:48, Masahiro Yamada wrote:
> 2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>:
>> This reverts commit 326ea45aa827da6686c78b5907f9839f91ef5782.
>>
>> After covering to use helper of_platform_default_populate() to
>> populate the default bus, no error in build uniphier driver as
>> a module.
> 
> This statement is weird.
> There is no error for building this driver as a module
> at the point of v4.5-rc1.

Yes, but after drop export of_default_bus_match_table in patchset(15/15),
we will meet build issue, so the statement can be changed to
------------
After covering to use helper of_platform_default_populate() to
populate the default bus, this driver can be safely as a tristate
one, no error in build uniphier driver as a module once we drop
export of_default_bus_match_table in later patch.
------------
> 
> The of_platform_default_populate() conversion (11/15) is unrelated
> to fixing the build error.
> 
> BTW, I had already posted an equivalent patch a few days before:
> 
> https://patchwork.kernel.org/patch/8096991/
> 
I didn't notice this before, it is ok for me to use your patch, or I will send
a new one with update changlog, thanks for your review.

> 
> 
> 
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  drivers/bus/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
>> index 129d47b..9a92c07 100644
>> --- a/drivers/bus/Kconfig
>> +++ b/drivers/bus/Kconfig
>> @@ -132,7 +132,7 @@ config SUNXI_RSB
>>           and AC100/AC200 ICs.
>>
>>  config UNIPHIER_SYSTEM_BUS
>> -       bool "UniPhier System Bus driver"
>> +       tristate "UniPhier System Bus driver"
>>         depends on ARCH_UNIPHIER && OF
>>         default y
>>         help
>> --
>> 2.6.0.GIT
>>
> 
>

[toc] | [prev] | [next] | [standalone]

#1318623 — [PATCH 07/15] cris: use of_platform_default_populate() to populate default bus

FromKefeng Wang <wangkefeng.wang@huawei.com>
Date2016-01-27 05:40 +0100
Subject[PATCH 07/15] cris: use of_platform_default_populate() to populate default bus
Message-ID<qVq3E-6sp-11@gated-at.bofh.it>
In reply to#1318606
Use helper of_platform_default_populate() in linux/of_platform
when possible, instead of calling of_platform_populate() with
the default match table.

Cc: Mikael Starvik <starvik@axis.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 arch/cris/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/cris/kernel/setup.c b/arch/cris/kernel/setup.c
index bb12aa9..5ee5dfc 100644
--- a/arch/cris/kernel/setup.c
+++ b/arch/cris/kernel/setup.c
@@ -215,7 +215,7 @@ subsys_initcall(topology_init);
 
 static int __init cris_of_init(void)
 {
-	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+	of_platform_default_populate(NULL, NULL, NULL);
 	return 0;
 }
 core_initcall(cris_of_init);
-- 
2.6.0.GIT

[toc] | [prev] | [next] | [standalone]

#1318624 — [PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus

FromKefeng Wang <wangkefeng.wang@huawei.com>
Date2016-01-27 05:40 +0100
Subject[PATCH 09/15] xtensa: use of_platform_default_populate() to populate default bus
Message-ID<qVq3D-6sp-3@gated-at.bofh.it>
In reply to#1318606
Use helper of_platform_default_populate() in linux/of_platform
when possible, instead of calling of_platform_populate() with
the default match table.

Cc: Chris Zankel <chris@zankel.net>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 arch/xtensa/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c
index 9735691..1b17fe9 100644
--- a/arch/xtensa/kernel/setup.c
+++ b/arch/xtensa/kernel/setup.c
@@ -255,7 +255,7 @@ void __init early_init_devtree(void *params)
 static int __init xtensa_device_probe(void)
 {
 	of_clk_init(NULL);
-	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+	of_platform_default_populate(NULL, NULL, NULL);
 	return 0;
 }
 
-- 
2.6.0.GIT

[toc] | [prev] | [next] | [standalone]

#1318626 — [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus

FromKefeng Wang <wangkefeng.wang@huawei.com>
Date2016-01-27 05:40 +0100
Subject[PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus
Message-ID<qVq3E-6sp-13@gated-at.bofh.it>
In reply to#1318606
Use helper of_platform_default_populate() in linux/of_platform
when possible, instead of calling of_platform_populate() with
the default match table.

Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/bus/uniphier-system-bus.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/bus/uniphier-system-bus.c b/drivers/bus/uniphier-system-bus.c
index 834a2ae..f50bd6d 100644
--- a/drivers/bus/uniphier-system-bus.c
+++ b/drivers/bus/uniphier-system-bus.c
@@ -257,8 +257,7 @@ static int uniphier_system_bus_probe(struct platform_device *pdev)
 	uniphier_system_bus_set_reg(priv);
 
 	/* Now, the bus is configured.  Populate platform_devices below it */
-	return of_platform_populate(dev->of_node, of_default_bus_match_table,
-				    NULL, dev);
+	return of_platform_default_populate(dev->of_node, NULL, dev);
 }
 
 static const struct of_device_id uniphier_system_bus_match[] = {
-- 
2.6.0.GIT

[toc] | [prev] | [next] | [standalone]

#1318965 — Re: [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-01-27 14:50 +0100
SubjectRe: [PATCH 11/15] bus: uniphier-system-bus: use of_platform_default_populate() to populate default bus
Message-ID<qVyDU-4eI-7@gated-at.bofh.it>
In reply to#1318626
Hi Kefeng,

2016-01-27 13:27 GMT+09:00 Kefeng Wang <wangkefeng.wang@huawei.com>:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/bus/uniphier-system-bus.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bus/uniphier-system-bus.c b/drivers/bus/uniphier-system-bus.c
> index 834a2ae..f50bd6d 100644
> --- a/drivers/bus/uniphier-system-bus.c
> +++ b/drivers/bus/uniphier-system-bus.c
> @@ -257,8 +257,7 @@ static int uniphier_system_bus_probe(struct platform_device *pdev)
>         uniphier_system_bus_set_reg(priv);
>
>         /* Now, the bus is configured.  Populate platform_devices below it */
> -       return of_platform_populate(dev->of_node, of_default_bus_match_table,
> -                                   NULL, dev);
> +       return of_platform_default_populate(dev->of_node, NULL, dev);
>  }
>
>  static const struct of_device_id uniphier_system_bus_match[] = {


I did not notice the existence of of_platform_default_populate().

If I had used this function, commit b80443cc22 would have not been
needed in the first place...

Thanks for cleaning this!

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>


-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web