Groups > linux.kernel > #1320099

Re: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list
Date	Thu, 28 Jan 2016 00:00:02 +0100
Message-ID	<qVHea-2ip-17@gated-at.bofh.it> (permalink)
References	<qULWz-1WT-35@gated-at.bofh.it> <qVrVL-7Tq-1@gated-at.bofh.it> <qVrVL-7Tq-3@gated-at.bofh.it>
User-Agent	KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="utf-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>, "Juri Lelli <Lelli" <juri.lelli@arm.com>
X-Original-Date	Wed, 27 Jan 2016 23:55:37 +0100
X-Original-Message-ID	<3098333.ng4zWfoJhM@vostro.rjw.lan>
X-Original-References	<1453715167-26165-1-git-send-email-ego@linux.vnet.ibm.com> <1453876346-21869-1-git-send-email-ego@linux.vnet.ibm.com> <20160127063611.GM3322@vireshk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1320099

Show key headers only | View raw

On Wednesday, January 27, 2016 12:06:11 PM Viresh Kumar wrote:
> On 27-01-16, 12:02, Gautham R. Shenoy wrote:
> > Currently next_policy() explicitly checks if a policy is the last
> > policy in the cpufreq_policy_list. Use the standard list_is_last
> > primitive instead.
> > 
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> > ---
> > The earlier version one was based on an Juri's experimental branch. 
> > I have based this one on linux-pm.git linux-next branch.
> > 
> >  drivers/cpufreq/cpufreq.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index c35e7da..e979ec7 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -48,11 +48,11 @@ static struct cpufreq_policy *next_policy(struct cpufreq_policy *policy,
> >  					  bool active)
> >  {
> >  	do {
> > -		policy = list_next_entry(policy, policy_list);
> > -
> >  		/* No more policies in the list */
> > -		if (&policy->policy_list == &cpufreq_policy_list)
> > +		if (list_is_last(&policy->policy_list, &cpufreq_policy_list))
> >  			return NULL;
> > +
> > +		policy = list_next_entry(policy, policy_list);
> >  	} while (!suitable_policy(policy, active));
> >  
> >  	return policy;
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied, thanks!

Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Use list_is_last() to check last entry of the policy list "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2016-01-25 10:50 +0100
  Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 11:00 +0100
    Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Juri Lelli <juri.lelli@arm.com> - 2016-01-25 12:20 +0100
      Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 12:30 +0100
        Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-27 07:00 +0100
      Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-27 07:10 +0100
        Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Juri Lelli <juri.lelli@arm.com> - 2016-01-27 11:20 +0100
          Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-27 12:20 +0100
  [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2016-01-27 07:40 +0100
    Re: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry  of the policy list Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-27 07:40 +0100
      Re: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-28 00:00 +0100

csiph-web