Re: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list
Date	2016-01-27 07:40 +0100
Message-ID	<qVrVL-7Tq-3@gated-at.bofh.it> (permalink)
References	<qULWz-1WT-35@gated-at.bofh.it> <qVrVL-7Tq-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 27-01-16, 12:02, Gautham R. Shenoy wrote:
> Currently next_policy() explicitly checks if a policy is the last
> policy in the cpufreq_policy_list. Use the standard list_is_last
> primitive instead.
> 
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> ---
> The earlier version one was based on an Juri's experimental branch. 
> I have based this one on linux-pm.git linux-next branch.
> 
>  drivers/cpufreq/cpufreq.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index c35e7da..e979ec7 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -48,11 +48,11 @@ static struct cpufreq_policy *next_policy(struct cpufreq_policy *policy,
>  					  bool active)
>  {
>  	do {
> -		policy = list_next_entry(policy, policy_list);
> -
>  		/* No more policies in the list */
> -		if (&policy->policy_list == &cpufreq_policy_list)
> +		if (list_is_last(&policy->policy_list, &cpufreq_policy_list))
>  			return NULL;
> +
> +		policy = list_next_entry(policy, policy_list);
>  	} while (!suitable_policy(policy, active));
>  
>  	return policy;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Use list_is_last() to check last entry of the policy list "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2016-01-25 10:50 +0100
  Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 11:00 +0100
    Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Juri Lelli <juri.lelli@arm.com> - 2016-01-25 12:20 +0100
      Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 12:30 +0100
        Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-27 07:00 +0100
      Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-27 07:10 +0100
        Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Juri Lelli <juri.lelli@arm.com> - 2016-01-27 11:20 +0100
          Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the  policy list Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-01-27 12:20 +0100
  [PATCH RESEND] cpufreq: Use list_is_last() to check last entry of the policy list "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> - 2016-01-27 07:40 +0100
    Re: [PATCH RESEND] cpufreq: Use list_is_last() to check last entry  of the policy list Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-27 07:40 +0100

csiph-web