Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1315117

Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller

Show all headers | View raw

On 22/01/2016 17:35, Måns Rullgård wrote:
> Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> 
>> On 20/01/2016 19:09, Måns Rullgård wrote:
>>
>>> Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
>>>
>>>> On 20/01/2016 17:38, Måns Rullgård wrote:
>>>>
>>>>> Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
>>>>>
>>>>>> On 20/01/2016 17:25, Måns Rullgård wrote:
>>>>>>
>>>>>>> Marc Zyngier <marc.zyngier@arm.com> writes:
>>>>>>>
>>>>>>>> On 20/01/16 16:10, Måns Rullgård wrote:
>>>>>>>>
>>>>>>>>> Marc Zyngier <marc.zyngier@arm.com> writes:
>>>>>>>>>
>>>>>>>>>>> +	if (of_property_read_u32(node, "reg", &ctl))
>>>>>>>>>>> +		panic("%s: failed to get reg base", node->name);
>>>>>>>>>>> +
>>>>>>>>>>> +	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>>>>>>>>>>> +	chip->ctl = ctl;
>>>>>>>>>>> +	chip->base = base;
>>>>>>>>>
>>>>>>>>> As I said before, this assumes the outer DT node uses a ranges
>>>>>>>>> property.  Normally reg properties work the same whether they specify an
>>>>>>>>> offset within an outer "ranges" or have a full address directly.  It
>>>>>>>>> would be easy enough to make this work with either, so I don't see any
>>>>>>>>> reason not to.
>>>>>>>>
>>>>>>>> Yup, that is a good point. I guess Marc can address this in the next
>>>>>>>> round, since we need a DT binding anyway.
>>>>>>>
>>>>>>> I'd suggest using of_address_to_resource() on both nodes and subtracting
>>>>>>> the start addresses returned.
>>>>>>
>>>>>> For my own reference, Marc Zyngier suggested:
>>>>>> "you should use of_iomap to map the child nodes, and not mess with
>>>>>> the parent one."
>>>>>
>>>>> That's going to get very messy since the generic irqchip code needs all
>>>>> the registers as offsets from a common base address.
>>>>
>>>> The two suggestions are over my head at the moment.
>>>>
>>>> Do you want to submit v4 and have Marc Z take a look?
>>>
>>> Done.  If this isn't acceptable either, I'm out of ideas that don't end
>>> up being far uglier than anything suggested so far.
>>
>> With your latest patch, can I drop the ranges property?
> 
> Why would you want to do that?

<confused> I thought that was the whole point of the v4 improvement?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 14:10 +0100
  Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-18 14:10 +0100
  Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:10 +0100
    [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:50 +0100
      Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:10 +0100
        Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:20 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:40 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:50 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 19:10 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:00 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:50 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:50 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:30 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:30 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 18:10 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Mark Rutland <mark.rutland@arm.com> - 2016-01-20 18:10 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100

csiph-web