Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1313326

Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller

From Måns Rullgård <mans@mansr.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller
Date 2016-01-20 17:20 +0100
Message-ID <qT3Ed-yP-3@gated-at.bofh.it> (permalink)
References <qShJf-13I-1@gated-at.bofh.it> <qSkxs-2ZZ-29@gated-at.bofh.it> <qSla9-3jC-5@gated-at.bofh.it> <qT3uy-vq-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Marc Zyngier <marc.zyngier@arm.com> writes:

>> +	if (of_property_read_u32(node, "reg", &ctl))
>> +		panic("%s: failed to get reg base", node->name);
>> +
>> +	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>> +	chip->ctl = ctl;
>> +	chip->base = base;

As I said before, this assumes the outer DT node uses a ranges
property.  Normally reg properties work the same whether they specify an
offset within an outer "ranges" or have a full address directly.  It
would be easy enough to make this work with either, so I don't see any
reason not to.

-- 
Måns Rullgård

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 14:10 +0100
  Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-18 14:10 +0100
  Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:10 +0100
    [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:50 +0100
      Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:10 +0100
        Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:20 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:40 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:50 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 19:10 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:00 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:50 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:50 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:30 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:30 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 18:10 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Mark Rutland <mark.rutland@arm.com> - 2016-01-20 18:10 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100

csiph-web