Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1311648

Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller

From Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller
Date 2016-01-18 17:10 +0100
Message-ID <qSkxs-2ZZ-29@gated-at.bofh.it> (permalink)
References <qShJf-13I-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 18/01/2016 13:56, Marc Gonzalez wrote:

> For the arch/arm/mach-tango port, I'm using this driver written
> by Mans. Version 1 of the patch was submitted two months ago:
> http://thread.gmane.org/gmane.linux.kernel/2089471
> 
> I've tried to address Marc Zyngier's remarks.

And my patch is incomplete, v3 coming right up.

drivers/irqchip/irq-tango.c: In function 'tangox_irq_init':
drivers/irqchip/irq-tango.c:183:6: warning: unused variable 'i' [-Wunused-variable]
  int i;
      ^
drivers/irqchip/irq-tango.c: In function 'tangox_of_irq_init':
drivers/irqchip/irq-tango.c:200:6: warning: 'name' may be used uninitialized in this function [-Wmaybe-uninitialized]
  err = irq_alloc_domain_generic_chips(dom, 32, 2, name, handle_level_irq,
      ^
drivers/irqchip/irq-tango.c:179:14: note: 'name' was declared here
  const char *name;
              ^

Regards.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 14:10 +0100
  Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-18 14:10 +0100
  Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:10 +0100
    [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:50 +0100
      Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:10 +0100
        Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:20 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:40 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:50 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 19:10 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:00 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:50 +0100
                Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:50 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:30 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
          Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:30 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 18:10 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100
            Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt  controller Mark Rutland <mark.rutland@arm.com> - 2016-01-20 18:10 +0100
              Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100

csiph-web