Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1313336
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller |
| Date | 2016-01-20 17:30 +0100 |
| Message-ID | <qT3NU-CC-11@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <qSkxs-2ZZ-29@gated-at.bofh.it> <qSla9-3jC-5@gated-at.bofh.it> <qT3uy-vq-5@gated-at.bofh.it> <qT3Ed-yP-3@gated-at.bofh.it> <qT3NU-CC-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> On 20/01/2016 17:10, Måns Rullgård wrote:
>
>> Marc Zyngier wrote:
>>
>>>> + if (of_property_read_u32(node, "reg", &ctl))
>>>> + panic("%s: failed to get reg base", node->name);
>>>> +
>>>> + chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>>>> + chip->ctl = ctl;
>>>> + chip->base = base;
>>
>> As I said before, this assumes the outer DT node uses a ranges
>> property. Normally reg properties work the same whether they specify an
>> offset within an outer "ranges" or have a full address directly. It
>> would be easy enough to make this work with either, so I don't see any
>> reason not to.
>
> IIRC, I was told very early in the review process that the ranges prop
> was mandatory. Lemme look for it... It was Arnd:
>
> http://thread.gmane.org/gmane.linux.ports.arm.kernel/444131/focus=444207
>
>> You are missing a ranges property that describes what address
>> space these addresses are in.
>>
>> 'ranges;' would be wrong here, as the interrupt controller is
>> not a bus. If you have no ranges property, the bus is interpreted
>> as having its own address space with no relation to the parent bus
>> (e.g. an I2C bus uses addresses that are not memory mapped).
>>
>> Just list the addresses that are actually decoded by child
>> devices here.
>
> Did I misunderstand?
It's still possible to create such a device tree, and that will fail in
very hard to debug ways. Better to be a bit robust.
--
Måns Rullgård
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 14:10 +0100
Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-18 14:10 +0100
Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:10 +0100
[RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:50 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:20 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:50 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 19:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:00 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:50 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:50 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:30 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:30 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 18:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Mark Rutland <mark.rutland@arm.com> - 2016-01-20 18:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100
csiph-web